[GitHub] [spark] cloud-fan commented on a change in pull request #32032: [SPARK-34701][SQL] Introduce TransformAfterAnalysis rule that allows a logical plan to be transformed after all the analysis rules run.

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #32032:
URL: https://github.com/apache/spark/pull/32032#discussion_r607179321



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/TransformationAfterAnalysis.scala
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.plans.logical
+
+/**
+ * A trait that exposes 'transform' which will be called by the `TransformAfterAnalysis` rule
+ * after all other analysis rules are called. One scenario to use this transformation is to
+ * remove any children of a logical plan so that they are not optimized; this is useful for
+ * commands that create a view or a cache because they need to work with analyzed plans.
+ */
+trait TransformationAfterAnalysis {
+  def transform: LogicalPlan

Review comment:
       This trait doesn't need to be so general. I think what we need here is to notify the node that the children are all resolved. e.g.
   ```
   trait AnalysisOnlyCommand extends Command {
     def markAsAnalyzed(): LogicalPlan
   }
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org