You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/02 07:12:26 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10081: [WIP] Add CLI for connections export (#9856)

mik-laj commented on a change in pull request #10081:
URL: https://github.com/apache/airflow/pull/10081#discussion_r464042185



##########
File path: airflow/cli/cli_parser.py
##########
@@ -626,6 +626,16 @@ def positive_int(value):
     ),
     action="store_true",
     default=False)
+ARG_CONN_EXPORT_FORMAT = Arg(
+    ('--format',),
+    help='Output format of the file for exporting the connections',
+    default='json',
+    type=str)
+ARG_CONN_EXPORT_FILE = Arg(
+    ('--output-file',),

Review comment:
       ```suggestion
       ('output-file',),
   ```
   What do you think about using positional arguments?
   Before:
   ```
   airflow connections export --output-file a.json
   ```
   Before:
   ```
   airflow connections export a.json
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org