You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/16 00:56:18 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #3787: Tame Gradle Project Loading
lkishalmi opened a new pull request #3787:
URL: https://github.com/apache/netbeans/pull/3787
@sdedic this is an attempt to tame the Gradle project loading methods and calls. My motivation was, that I started to get lost in the calls when a Gradle project, loaded re-loaded.
What I'm trying here is to move the options of the different kind of re-loads into a separate class as [GradleLoadOptions](extide/gradle/src/org/netbeans/modules/gradle/loaders/GradleLoadOptions.java) so the code can be more descriptive, and the usage of certain load flags could be more easily tracked. I could be completely wrong with this PR and my approach could be wrong as well. Your feedback is essential.
I've tried not to break things, though made a few not compatible changes. loadedProjectSerial and currentSerial in NBGradleProjectImpl were moved to a new sequence field to GradleProject, so dumpProject() cannot set the loadedProjectSerial to zero.
Tests seems to be fine, save NbGradleProjectImpl.testEventsProcessedBeforeCompletion() which hangs in infinite wait. Unfortunately I could not crack what that test really does, so I need some help there.
There are some unused code mentioning GradleLoadContext that shall be ignored.
I have purposefully not changed the javadoc on the load methods yet, so the former parameters can be looked up while replacing the calls with GradleLoadOptions arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3787: Tame Gradle Project Loading
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3787:
URL: https://github.com/apache/netbeans/pull/3787#issuecomment-1070970837
Marked as wip, as this is still in a draft, "let's talk about it" phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #3787: Tame Gradle Project Loading
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #3787:
URL: https://github.com/apache/netbeans/pull/3787#issuecomment-1070970837
Marked as wip, as this is still in a draft, "let's talk about it" phase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #3787: Tame Gradle Project Loading
Posted by GitBox <gi...@apache.org>.
sdedic commented on pull request #3787:
URL: https://github.com/apache/netbeans/pull/3787#issuecomment-1070516239
ok to review now, or is it still being overhauled (it's marked as wip) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists