You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by wa...@apache.org on 2016/01/15 20:59:02 UTC
hadoop git commit: HADOOP-12713. Disable spurious checkstyle checks.
Repository: hadoop
Updated Branches:
refs/heads/trunk c07f7fa8f -> 5d5a22a87
HADOOP-12713. Disable spurious checkstyle checks.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/5d5a22a8
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/5d5a22a8
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/5d5a22a8
Branch: refs/heads/trunk
Commit: 5d5a22a878d185dd996a921d681863c4bc44e6b8
Parents: c07f7fa
Author: Andrew Wang <wa...@apache.org>
Authored: Fri Jan 15 11:58:56 2016 -0800
Committer: Andrew Wang <wa...@apache.org>
Committed: Fri Jan 15 11:58:56 2016 -0800
----------------------------------------------------------------------
.../src/main/resources/checkstyle/checkstyle.xml | 12 +++++++-----
hadoop-common-project/hadoop-common/CHANGES.txt | 2 ++
2 files changed, 9 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/5d5a22a8/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
----------------------------------------------------------------------
diff --git a/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml b/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
index de7319c..74faa48 100644
--- a/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
+++ b/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml
@@ -61,7 +61,8 @@
<!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
<module name="Translation"/>
- <module name="FileLength"/>
+ <!-- We have many existing long files, this check ends up being spurious -->
+ <!--<module name="FileLength">-->
<module name="FileTabCharacter"/>
<module name="TreeWalker">
@@ -130,13 +131,14 @@
<module name="ParenPad"/>
<module name="TypecastParenPad"/>
<module name="WhitespaceAfter">
- <property name="tokens" value="COMMA, SEMI"/>
- </module>
+ <property name="tokens" value="COMMA, SEMI"/>
+ </module>
<!-- Modifier Checks -->
<!-- See http://checkstyle.sf.net/config_modifiers.html -->
- <module name="ModifierOrder"/>
+ <!-- This one is nitty, disable -->
+ <!-- <module name="ModifierOrder"/> -->
<module name="RedundantModifier"/>
@@ -178,7 +180,7 @@
<property name="basicOffset" value="2" />
<property name="caseIndent" value="0" />
</module>
- <module name="TodoComment"/>
+ <!--<module name="TodoComment"/>-->
<module name="UpperEll"/>
</module>
http://git-wip-us.apache.org/repos/asf/hadoop/blob/5d5a22a8/hadoop-common-project/hadoop-common/CHANGES.txt
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/CHANGES.txt b/hadoop-common-project/hadoop-common/CHANGES.txt
index 90013af..19f6fec 100644
--- a/hadoop-common-project/hadoop-common/CHANGES.txt
+++ b/hadoop-common-project/hadoop-common/CHANGES.txt
@@ -669,6 +669,8 @@ Release 2.9.0 - UNRELEASED
HADOOP-8887. Use a Maven plugin to build the native code using CMake
(cmccabe)
+ HADOOP-12713. Disable spurious checkstyle checks. (wang)
+
BUG FIXES
HADOOP-12655. TestHttpServer.testBindAddress bind port range is wider