You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "raboof (via GitHub)" <gi...@apache.org> on 2024/12/30 11:19:39 UTC

[PR] Don't update mockito major version [commons-bcel]

raboof opened a new pull request, #400:
URL: https://github.com/apache/commons-bcel/pull/400

   Mockito 5 uses Java 11
   
   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       https://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
   
   Before you push a pull request, review this list:
   
   - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2572987135

   I agree (though we should replace it with a PR that uses the mockito version from the parent pom)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2565519195

   > Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT?
   
   It seems to be pretty widely used, so I guess that would make sense?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2573008746

   > https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?
   
   You're right, fixing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2573006150

   > Hi @raboof Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references.
   
   :+1: 
   
   > In the meantime, would you help review the other Commons release candidates?
   > 
   >     * Codec: https://lists.apache.org/thread/66fvglm37rgt4hc8wzz6q3p5syctj1pf
   
   will do
   
   >     * BeanUtils 1: https://lists.apache.org/thread/g1xtov6k6w4ms2sb588f51z4y17dynz6
   
   https://dist.apache.org/repos/dist/dev/commons/beanutils/1.10.0-RC1 seems to be missing?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2572978915

   I don't think we need this change since `commons-parent` will define the Mockito version when the next version is released later today.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2572994061

   Hi @raboof 
   Once commons-parent is released, I'll kick off Dependabot builds and we'll first have to account for any changes due to the Doxia 1 to 2 upgrade, then we can clean up the Mockito references.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Don't update mockito major version [commons-bcel]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #400:
URL: https://github.com/apache/commons-bcel/pull/400#issuecomment-2565505878

   Hmm, I was hoping to avoid customizing GH this way for builds here and there. I wonder if we should just put the Java 8 based version for this jar in the parent POM and avoid this. WDYT? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org