You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by rx...@apache.org on 2015/11/25 22:51:34 UTC
spark git commit: [SPARK-11983][SQL] remove all unused codegen
fallback trait
Repository: spark
Updated Branches:
refs/heads/master ecac28354 -> 21e560641
[SPARK-11983][SQL] remove all unused codegen fallback trait
Author: Daoyuan Wang <da...@intel.com>
Closes #9966 from adrian-wang/removeFallback.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/21e56064
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/21e56064
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/21e56064
Branch: refs/heads/master
Commit: 21e5606419c4b7462d30580c549e9bfa0123ae23
Parents: ecac283
Author: Daoyuan Wang <da...@intel.com>
Authored: Wed Nov 25 13:51:30 2015 -0800
Committer: Reynold Xin <rx...@databricks.com>
Committed: Wed Nov 25 13:51:30 2015 -0800
----------------------------------------------------------------------
.../scala/org/apache/spark/sql/catalyst/expressions/Cast.scala | 3 +--
.../spark/sql/catalyst/expressions/regexpExpressions.scala | 4 ++--
.../spark/sql/catalyst/expressions/NonFoldableLiteral.scala | 3 +--
3 files changed, 4 insertions(+), 6 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/21e56064/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
index 533d17e..a2c6c39 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
@@ -104,8 +104,7 @@ object Cast {
}
/** Cast the child expression to the target data type. */
-case class Cast(child: Expression, dataType: DataType)
- extends UnaryExpression with CodegenFallback {
+case class Cast(child: Expression, dataType: DataType) extends UnaryExpression {
override def toString: String = s"cast($child as ${dataType.simpleString})"
http://git-wip-us.apache.org/repos/asf/spark/blob/21e56064/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
index 9e484c5..adef605 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
@@ -66,7 +66,7 @@ trait StringRegexExpression extends ImplicitCastInputTypes {
* Simple RegEx pattern matching function
*/
case class Like(left: Expression, right: Expression)
- extends BinaryExpression with StringRegexExpression with CodegenFallback {
+ extends BinaryExpression with StringRegexExpression {
override def escape(v: String): String = StringUtils.escapeLikeRegex(v)
@@ -117,7 +117,7 @@ case class Like(left: Expression, right: Expression)
case class RLike(left: Expression, right: Expression)
- extends BinaryExpression with StringRegexExpression with CodegenFallback {
+ extends BinaryExpression with StringRegexExpression {
override def escape(v: String): String = v
override def matches(regex: Pattern, str: String): Boolean = regex.matcher(str).find(0)
http://git-wip-us.apache.org/repos/asf/spark/blob/21e56064/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala
index 31ecf4a..118fd69 100644
--- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala
+++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NonFoldableLiteral.scala
@@ -26,8 +26,7 @@ import org.apache.spark.sql.types._
* A literal value that is not foldable. Used in expression codegen testing to test code path
* that behave differently based on foldable values.
*/
-case class NonFoldableLiteral(value: Any, dataType: DataType)
- extends LeafExpression with CodegenFallback {
+case class NonFoldableLiteral(value: Any, dataType: DataType) extends LeafExpression {
override def foldable: Boolean = false
override def nullable: Boolean = true
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org