You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by GitBox <gi...@apache.org> on 2019/06/15 23:31:31 UTC

[GitHub] [lucene-solr] colvinco opened a new pull request #723: SOLR-13545: AutoClose stream in ContentStreamUpdateRequest

colvinco opened a new pull request #723: SOLR-13545: AutoClose stream in ContentStreamUpdateRequest
URL: https://github.com/apache/lucene-solr/pull/723
 
 
   <!--
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   As discussed on SOLR-13545, ContentStreamUpdateRequest doesn't close the InputStream it creates, after a change made in SOLR-12142
   
   # Solution
   
   Use try-with-resources to autoclose the stream
   
   # Tests
   
   I've updated existing tests that make update requests backed by file streams, so that they attempt to delete the file they have streamed to Solr. If the stream isn't closed, the test will fail on Windows, since the file will be locked. On Linux the file will appear to be deleted even if the stream isn't immediately closed.
   
   I think the alternative would be to change the request classes to expose the InputStream so that it can be mocked or spied on, to explicitly check that close is called, but that also feels fragile.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request title.
   - [X] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `ant precommit` and the appropriate test suite.
   - [X] I have added tests for my changes.
   - [] I have added documentation for the Ref Guide (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org