You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2018/04/04 19:39:09 UTC
[GitHub] nifi pull request #2605: NIFI-4862: Keep incoming flowfile attributes in out...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2605
NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from SelectHiveQL
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4862
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2605.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2605
----
commit cbd0e10b9ef6d692841b551764388c5973bdfb75
Author: Matthew Burgess <ma...@...>
Date: 2018-04-04T19:38:24Z
NIFI-4862: Keep incoming flowfile attributes in outgoing flowfiles from SelectHiveQL
----
---
[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2605
@ijokarumawak Mind taking a look at this one? It changed the order of provenance events so it touched your code for emitting a FETCH-FORK (now it's a FORK-FETCH). Just want to make sure the provenance chain is clear, simple, and complete. Thanks in advance!
---
[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2605
@mattyb149 I'm going to review it, thanks!
---
[GitHub] nifi pull request #2605: NIFI-4862: Keep incoming flowfile attributes in out...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2605
---
[GitHub] nifi issue #2605: NIFI-4862: Keep incoming flowfile attributes in outgoing f...
Posted by ijokarumawak <gi...@git.apache.org>.
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2605
@mattyb149 Thanks for the fix. I confirmed the attributes in the incoming FlowFile are carried to the outgoing FlowFiles. Two FlowFiles were created by SelectHiveQL in the flow below, from 1 incoming FlowFile. NiFi provenance events look correct. I was able to render following graph with Atlas.
LGTM +1, merging to master.
---