You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2016/03/17 17:14:29 UTC
[GitHub] incubator-trafodion pull request: JIRA 1852: disallow reserved nam...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/390
JIRA 1852: disallow reserved names as user columns
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion resrvdcols_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/390.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #390
----
commit a3af80d590d3e31e268c38e728aa7a31a482aaf3
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-13T22:13:35Z
commit #1
commit db44c1d716d44e07f5d01ba13d01b1cc4fdd2d3b
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-13T22:13:44Z
Merge remote branch 'origin/master' into resrvdcols_br
commit 57a7566fab823bc45a01121cfa953bff18504378
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-16T22:55:51Z
Merge remote branch 'origin/master' into resrvdcols_br
commit a33ee6b9a6aa3186508ca528ffe744e4d4ea8f18
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-16T23:07:20Z
commit #2
commit 950a303f36591af03814a892694289edeb968f8e
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-17T01:46:23Z
Merge remote branch 'origin/master' into resrvdcols_br
Conflicts:
core/sql/common/ComMisc.cpp
core/sql/optimizer/BindItemExpr.cpp
core/sql/regress/seabase/EXPECTED020
core/sql/regress/seabase/TEST020
core/sql/sqlcomp/nadefaults.cpp
commit 5cdf688ff81d3813f233af90fbc376f6d65deca2
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-17T15:16:15Z
JIRA 1852: disallow reserved names as user columns
commit 14b17ddd9c591eb75bf9a9a0dc5c085f3c7dee04
Author: Cloud User <ce...@ansharma-3.novalocal>
Date: 2016-03-17T15:56:54Z
JIRA 1852: disallow reserved names as user columns
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1852: disallow reserved nam...
Posted by anoopsharma00 <gi...@git.apache.org>.
Github user anoopsharma00 commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/390#discussion_r56667942
--- Diff: core/sql/common/ComMisc.cpp ---
@@ -228,3 +228,17 @@ NAString ComConvertTrafNameToNativeName(
return convertedName;
}
+NABoolean ComTrafReservedColName(
+ const NAString &colName)
--- End diff --
If column is not delimited, then it will be upcased when this method is called.
If column is delimited ("a"), then it will retain the original case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1852: disallow reserved nam...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/390
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1852: disallow reserved nam...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/390#discussion_r56532290
--- Diff: core/sql/common/ComMisc.cpp ---
@@ -228,3 +228,17 @@ NAString ComConvertTrafNameToNativeName(
return convertedName;
}
+NABoolean ComTrafReservedColName(
+ const NAString &colName)
--- End diff --
I take it that by the time we get here, colName has already been case-shifted to upper case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---