You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/11 21:20:16 UTC

[GitHub] [incubator-superset] craig-rueda commented on a change in pull request #8214: [talisman] Enforcing HTTP for status checks

craig-rueda commented on a change in pull request #8214: [talisman] Enforcing HTTP for status checks
URL: https://github.com/apache/incubator-superset/pull/8214#discussion_r323464836
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -629,16 +630,19 @@ class DashboardAddView(DashboardModelView):  # noqa
 appbuilder.add_view_no_menu(DashboardAddView)
 
 
+@talisman(force_https=False)
 
 Review comment:
   Assuming these are needed so that some internal health check passes with TLS being handled by a LB or reverse proxy... 👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org