[jira] [Updated] (REEF-1079) Fix TestNamedParameterWithAliasRoundTrip test failures

["Mariia Mykhailova (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/REEF-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mariia Mykhailova updated REEF-1079:
------------------------------------
    Summary: Fix TestNamedParameterWithAliasRoundTrip test failures  (was: Put a lock in ProtocolBufferClassHierarchy.SerializeNode)

> Fix TestNamedParameterWithAliasRoundTrip test failures
> ------------------------------------------------------
>
>                 Key: REEF-1079
>                 URL: https://issues.apache.org/jira/browse/REEF-1079
>             Project: REEF
>          Issue Type: Bug
>            Reporter: Mariia Mykhailova
>            Assignee: Mariia Mykhailova
>
> The method {{ProtocolBufferClassHierarchy.SerializeNode}} iterates over all children of a node, serializing them one by one.
> {noformat}
> foreach (INode child in n.GetChildren())
> {
>     children.Add(SerializeNode(child));
> }
> {noformat}
> If the list of children is changed in a different thread, this code will throw {{System.InvalidOperationException : Collection was modified after the enumerator was instantiated.}}. We observe this in {{TestNamedParameterWithAliasRoundTrip}} test which passes when executed individually but fails when executed in parallel with other tests which don't do serialization, just use default {{ClassHierarchy}}.
> We need to fix the failures of this test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)