[jira] [Comment Edited] (LUCENE-4797) Fix remaining Lucene/Solr Javadocs issue

["Uwe Schindler (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14310810#comment-14310810 ] 

Uwe Schindler edited comment on LUCENE-4797 at 2/7/15 4:41 PM:
---------------------------------------------------------------

I think in branch_5x we can still enable doclint for the javadocs call easily. common-build.xml conditionally enables {{-Xdoclint:none}} there. So we can simply change that to the same options like in trunk. The doclint:none was needed to prevent failures on Java 8.

A similar condition culd be used for javac and then we have all features. I am just not 100% sure if javac allows doclint with -source/-target 1.7. But its worth a try.


was (Author: thetaphi):
I think in branch_5x we can still enable doclint for the javadocs call easily. common-build.xml conditionally enables {{-Xdoclint:none}} there. So we can simply change that to the same options like in trunk. The doclint:none was needed to prevent failures on Java 8.

> Fix remaining Lucene/Solr Javadocs issue
> ----------------------------------------
>
>                 Key: LUCENE-4797
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4797
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: general/javadocs
>    Affects Versions: 4.1
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>              Labels: Java8
>
> Java 8 has a new feature (enabled by default): http://openjdk.java.net/jeps/172
> It fails the build on:
> - incorrect links (@see, @link,...)
> - incorrect HTML entities
> - invalid HTML in general
> Thanks to our linter written in HTMLTidy and Python, most of the bugs are already solved in our source code, but the Oracle Linter finds some more problems, our linter does not:
> - missing escapes <
> - invalid entities
> Unfortunately the versions of JDK8 released up to today have a bug, making optional closing tags (which are valid HTML4), like </p>, mandatory. This will be fixed in b78.
> Currently there is another bug in the Oracle javadocs tool (it fails to copy doc-files folders), but this is under investigation at the moment.
> We should clean up our javadocs, so the pass the new JDK8 javadocs tool with build 78+. Maybe we can put our own linter out of service, once we rely on Java 8 :-)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org