[I] Build failure when default features are disabled [datafusion-ballista]

["milenkovicm (via GitHub)" <gi...@apache.org>]

milenkovicm opened a new issue, #1254:
URL: https://github.com/apache/datafusion-ballista/issues/1254

   **Describe the bug**
   
   when default features are disabled 
   
   ```toml
   ballista = { version = "44", default-features = false }
   ballista-scheduler = { version = "44", default-features = false }
   ballista-executor = { version = "44", default-features = false }
   ```
   
   build fails with: 
   
   ```
   error[E0432]: unresolved import `clap`
     --> /Users/marko/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ballista-scheduler-44.0.0/src/cluster/mod.rs:22:5
      |
   22 | use clap::ValueEnum;
      |     ^^^^ use of unresolved module or unlinked crate `clap`
      |
      = help: if you wanted to use a crate named `clap`, use `cargo add clap` to add it to your `Cargo.toml`
   
   For more information about this error, try `rustc --explain E0432`.
   error: could not compile `ballista-scheduler` (lib) due to 1 previous error
   ```
   
   looks like one of structures are not gated with `cfg`
   
   ```rust
   // an enum used to configure the backend
   // needs to be visible to code generated by configure_me
   #[derive(Debug, Clone, ValueEnum, serde::Deserialize, PartialEq, Eq)]
   pub enum ClusterStorage {
       Memory,
   }
   
   impl std::str::FromStr for ClusterStorage {
       type Err = String;
   
       fn from_str(s: &str) -> std::result::Result<Self, Self::Err> {
           ValueEnum::from_str(s, true)
       }
   }
   ```
   
   **To Reproduce**
   
   as mentioned in previous paragraph
   
   **Expected behavior**
   
   build to compile in this case as well
   
   **Additional context**
   
   we should add a test to cover this case 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org

Re: [I] Build failure when default features are disabled [datafusion-ballista]

["milenkovicm (via GitHub)" <gi...@apache.org>]

milenkovicm closed issue #1254: Build failure when default features are disabled
URL: https://github.com/apache/datafusion-ballista/issues/1254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org