You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/09 21:14:47 UTC
[GitHub] [arrow-rs] alamb opened a new pull request #534: Add tests for building with feature gates ["simd"]
alamb opened a new pull request #534:
URL: https://github.com/apache/arrow-rs/pull/534
# Which issue does this PR close?
re #458
Built on #532 and https://github.com/apache/arrow-rs/pull/533/ so review them first
# Rationale for this change
There are reports that user applications can't be built against arrow using the simd feature gate and I wanted to increase test coverage
# What changes are included in this PR?
tests and clean up some warnings
# Are there any user-facing changes?
no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] codecov-commenter commented on pull request #534: Add tests for building with feature gates ["simd"]
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #534:
URL: https://github.com/apache/arrow-rs/pull/534#issuecomment-877465994
# [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#534](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ef5319) into [master](https://codecov.io/gh/apache/arrow-rs/commit/f1fb2b11bbd6350365de010d3e1d676a27602d3a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f1fb2b1) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 167 167
Lines 45984 45984
=======================================
Hits 37984 37984
Misses 8000 8000
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [arrow/src/compute/kernels/comparison.rs](https://codecov.io/gh/apache/arrow-rs/pull/534/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YXJyb3cvc3JjL2NvbXB1dGUva2VybmVscy9jb21wYXJpc29uLnJz) | `95.84% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f1fb2b1...7ef5319](https://codecov.io/gh/apache/arrow-rs/pull/534?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #534: Add tests for building with feature gates ["simd"]
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #534:
URL: https://github.com/apache/arrow-rs/pull/534#discussion_r668651577
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -591,7 +591,7 @@ where
let bitmask = T::mask_to_u64(&simd_result);
let bytes = bitmask.to_le_bytes();
- &result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
+ result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
Review comment:
Yes -- sorry -- I should have mentioned that. When I was testing the project with `simd` locally this was flagged as a compiler warning so I fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #534: Add tests for building with feature gates ["simd"]
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #534:
URL: https://github.com/apache/arrow-rs/pull/534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] nevi-me commented on a change in pull request #534: Add tests for building with feature gates ["simd"]
Posted by GitBox <gi...@apache.org>.
nevi-me commented on a change in pull request #534:
URL: https://github.com/apache/arrow-rs/pull/534#discussion_r668229719
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -591,7 +591,7 @@ where
let bitmask = T::mask_to_u64(&simd_result);
let bytes = bitmask.to_le_bytes();
- &result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
+ result_slice[0..lanes / 8].copy_from_slice(&bytes[0..lanes / 8]);
Review comment:
Seems unrelated, was it a `needless borrow` clippy lint?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org