You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by lovexi <gi...@git.apache.org> on 2016/07/31 08:50:35 UTC

[GitHub] spark pull request #14428: [SPARK-16810] Refactor registerSinks with multipl...

GitHub user lovexi opened a pull request:

    https://github.com/apache/spark/pull/14428

    [SPARK-16810] Refactor registerSinks with multiple constructos

    ## What changes were proposed in this pull request?
    
    For some metrics, it may require some **app detailed information** from `SparkConf`. So for those sinks, we need to pass `SparkConf` via sink constructor. Refactored registerSink class reflection part to allow multiple types of sink constructor to be initialized.
    
    ## How was this patch tested?
    
    Using existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lovexi/spark metrics-system

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14428
    
----
commit 74ff37b9ddef5733ddb2e967ca5d39335de9d542
Author: Yangyang Liu <ya...@fb.com>
Date:   2016-07-31T08:48:52Z

    Refactor registerSinks with multiple constructos

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by rxin <gi...@git.apache.org>.

Github user rxin commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    They should be visible in test scope, shouldn't they?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by lovexi <gi...@git.apache.org>.

Github user lovexi commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    Reopen PR #14415 @rxin 
    
    >> DId you add a test?
    
    I was trying to add a unit test for this feature. But the test sinks are not visible for MetricsSystem when it tries to register test sink classes since test sinks are hidden in test packages. Is there any other ways to load test classes for MetricsSystem without messed-up metrics package?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by lovexi <gi...@git.apache.org>.

Github user lovexi commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    I think this one is ready for reviews. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    **[Test build #63236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63236/consoleFull)** for PR 14428 at commit [`c9d497b`](https://github.com/apache/spark/commit/c9d497bdd7db8a467d9328db93fec7316714870b).
     * This patch **fails Spark unit tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14428: [SPARK-16810] Refactor registerSinks with multiple const...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14428
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63236/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org