You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/04/21 14:02:24 UTC
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/
-----------------------------------------------------------
(Updated April 21, 2015, 2:02 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
Changes
-------
making review public.
Bugs: MESOS-2620
https://issues.apache.org/jira/browse/MESOS-2620
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
Diff: https://reviews.apache.org/r/33296/diff/
Testing
-------
make check and manual tests.
Thanks,
Alexander Rojas
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review80959
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33295, 33296]
All tests passed.
- Mesos ReviewBot
On April 21, 2015, 12:02 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 12:02 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 7cce3a0bb808a1cb7bac9acab31eb1c67a15ea9f
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81308
-----------------------------------------------------------
include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131635>
Check the comment formatting, please.
include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131637>
Might be a good idea to add a comment on why this message name is using plural even though it currently contains only a single rule.
include/mesos/mesos.proto
<https://reviews.apache.org/r/33296/#comment131647>
I am unsure if `include/mesos.proto` is the _right_ place for this given that this message does not need to get exposed. As this forms the base of more definitions to come, I would like to propose adding a new .proto file specifically for this. How about using `src/messages/firewall.proto` & `src/messages/firewall.hpp` with the package / namespace `mesos.internal.firewall` and use `Rules` as the name instead?
So now we have `process::FirewallRule` and `mesos::FirewallRules` (proto message). That seems a bit unfortunate, especially due to the fact hat `FirewallRules` is __not__ composed by repeated `FirewallRule`.
How about `mesos::internal::firewall::Rules` (proto message) and `process::FirewallRule` instead? Note however that I feel rather unsure about the best way here.
src/master/flags.cpp
<https://reviews.apache.org/r/33296/#comment131638>
s/FirewallRule/FirewallRules/
src/master/main.cpp
<https://reviews.apache.org/r/33296/#comment131639>
- Till Toenshoff
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81337
-----------------------------------------------------------
src/master/flags.cpp
<https://reviews.apache.org/r/33296/#comment131675>
Could you add these flags also to the documentation? I.e. http://mesos.apache.org/documentation/latest/configuration/
src/slave/flags.cpp
<https://reviews.apache.org/r/33296/#comment131676>
Please add to documentation http://mesos.apache.org/documentation/latest/configuration/
- Joerg Schad
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 23, 2015, 7:27 p.m., Benjamin Hindman wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > s/template<>/template <>/
> >
> > (Here and everywhere else please!)
>
> Alexander Rojas wrote:
> Now in review [33730](https://reviews.apache.org/r/33730/) (It needed to be fixed in the whole file).
Discarded the fix because this patch no longer modifies anything in that file, now it stands as a standalone patch at [33733](https://reviews.apache.org/r/33733/).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81343
-----------------------------------------------------------
On May 1, 2015, 12:39 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 12:39 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
> src/messages/flags.hpp PRE-CREATION
> src/messages/flags.proto PRE-CREATION
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 23, 2015, 7:27 p.m., Benjamin Hindman wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > s/template<>/template <>/
> >
> > (Here and everywhere else please!)
Now in review [33730](https://reviews.apache.org/r/33730/) (It needed to be fixed in the whole file).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81343
-----------------------------------------------------------
On April 22, 2015, 4:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 4:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81343
-----------------------------------------------------------
src/common/parse.hpp
<https://reviews.apache.org/r/33296/#comment131683>
s/template<>/template <>/
(Here and everywhere else please!)
src/master/main.cpp
<https://reviews.apache.org/r/33296/#comment131687>
const?
- Benjamin Hindman
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/
-----------------------------------------------------------
(Updated May 1, 2015, 12:39 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
Changes
-------
Moves protobuf defining the firewall rules format to a new `flags.proto` file. Adds documentation.
Bugs: MESOS-2620
https://issues.apache.org/jira/browse/MESOS-2620
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
src/messages/flags.hpp PRE-CREATION
src/messages/flags.proto PRE-CREATION
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
Diff: https://reviews.apache.org/r/33296/diff/
Testing
-------
make check and manual tests.
Thanks,
Alexander Rojas
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/
-----------------------------------------------------------
(Updated April 30, 2015, 10:14 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
Changes
-------
Just updates the patch to accomodate for changes on its parent one.
Bugs: MESOS-2620
https://issues.apache.org/jira/browse/MESOS-2620
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/mesos.proto 967b1e3bbfb3f6b71d5a15d02cba7ed5ec21816f
include/mesos/type_utils.hpp 044637481e5405d4d6f61653a9f9386edd191deb
src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
Diff: https://reviews.apache.org/r/33296/diff/
Testing
-------
make check and manual tests.
Thanks,
Alexander Rojas
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81160
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33295, 33296]
All tests passed.
- Mesos ReviewBot
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 23, 2015, 7:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > nit: `s/template<>/template <>/`
>
> Alexander Rojas wrote:
> I was checking and all the entries in this file have the from `template<>` should I change them all?
>
> Michael Park wrote:
> Yes please!
>
> Alexander Rojas wrote:
> Fix in review [33730](https://reviews.apache.org/r/33730/)
Discarded the fix because this patch no longer modifies anything in that file, now it stands as a standalone patch at [33733](https://reviews.apache.org/r/33733/).
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------
On May 1, 2015, 12:39 a.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated May 1, 2015, 12:39 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> docs/configuration.md 54c4e31ed6dfed3c23d492c19a301ce119a0519b
> src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 18f8c3178459da0cbf23a1817ec49cd9d3998bfd
> src/messages/flags.hpp PRE-CREATION
> src/messages/flags.proto PRE-CREATION
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Michael Park <mc...@gmail.com>.
> On April 23, 2015, 5:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > nit: `s/template<>/template <>/`
>
> Alexander Rojas wrote:
> I was checking and all the entries in this file have the from `template<>` should I change them all?
Yes please!
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 23, 2015, 7:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > nit: `s/template<>/template <>/`
>
> Alexander Rojas wrote:
> I was checking and all the entries in this file have the from `template<>` should I change them all?
>
> Michael Park wrote:
> Yes please!
Fix in review [33730](https://reviews.apache.org/r/33730/)
> On April 23, 2015, 7:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 60
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line60>
> >
> > nit: `s/template<>/template <>/`
Fix in review [33730](https://reviews.apache.org/r/33730/)
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------
On April 22, 2015, 4:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 4:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
> On April 23, 2015, 7:20 p.m., Michael Park wrote:
> > src/common/parse.hpp, line 46
> > <https://reviews.apache.org/r/33296/diff/2/?file=939522#file939522line46>
> >
> > nit: `s/template<>/template <>/`
I was checking and all the entries in this file have the from `template<>` should I change them all?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------
On April 22, 2015, 4:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 4:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/#review81340
-----------------------------------------------------------
src/common/parse.hpp
<https://reviews.apache.org/r/33296/#comment131678>
nit: `s/template<>/template <>/`
src/common/parse.hpp
<https://reviews.apache.org/r/33296/#comment131679>
nit: `s/template<>/template <>/`
- Michael Park
On April 22, 2015, 2:36 p.m., Alexander Rojas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33296/
> -----------------------------------------------------------
>
> (Updated April 22, 2015, 2:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
>
>
> Bugs: MESOS-2620
> https://issues.apache.org/jira/browse/MESOS-2620
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
> include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
> src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
> src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
> src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
> src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
> src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
> src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
> src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
>
> Diff: https://reviews.apache.org/r/33296/diff/
>
>
> Testing
> -------
>
> make check and manual tests.
>
>
> Thanks,
>
> Alexander Rojas
>
>
Re: Review Request 33296: Added a flag which controls libprocess
firewall initialzation.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33296/
-----------------------------------------------------------
(Updated April 22, 2015, 4:36 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Till Toenshoff.
Changes
-------
Update to accomodate to the changes in parent patch.
Bugs: MESOS-2620
https://issues.apache.org/jira/browse/MESOS-2620
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
include/mesos/mesos.proto 3a8e8bf303e0576c212951f6028af77e54d93537
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/common/parse.hpp 547b32041f39f0ff0c38179b66a32b2239134abc
src/master/flags.hpp 996cf38c88f9718e55e88d6e906b5e3d1989478a
src/master/flags.cpp 5798989d3f135978ec3d5f714b1cd8d84180fc90
src/master/main.cpp 88bb39d57ea7d654bea11a3db0cf0903b4b22d99
src/slave/flags.hpp d3b1ce117fbb4e0b97852ef150b63f35cc991032
src/slave/flags.cpp d0932b04e3825abb6173efe0d1aee199aa356932
src/slave/main.cpp c62d3ab9825bf952071e8e312d383a0cb46547d2
Diff: https://reviews.apache.org/r/33296/diff/
Testing
-------
make check and manual tests.
Thanks,
Alexander Rojas