You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Donghui Xu (Code Review)" <ge...@cloudera.org> on 2017/06/14 09:29:56 UTC
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Donghui Xu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7179
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/1
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 9:
> Hi,Jim.I pull this patch by download the url, rebase it to master
> branch, then submit new code, but it doesn't resolve the conflict.
> Would you please resolve the conflict please?
> Thank you.
I notice you have been contributing several patches to Impala recently. As a member of the PPMC, welcome, and I'm glad to have you contributing!
Resolving merge conflicts is a routine part of the patch submission process, but, as you have noticed, that doesn't make it easy to learn. I am happy to help you learn. In my last response on this patch, I said,
"It would also be good to record, this next time you try, exactly which steps you took so you can copy-and-paste them here for diagnosis."
Can you please copy-and-paste the exact commands you entered into your terminal so I can help you resolve this?
If that terminal is closed, can you please re-try your efforts, recording this time the exact commands you entered into your terminal?
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 6:
(1 comment)
I hava added description about underscores. Than you.
http://gerrit.cloudera.org:8080/#/c/7179/5/shell/option_parser.py
File shell/option_parser.py:
Line 164: " contains alphanumeric characters or underscores.")
> This actually is incorrect - it can also contain underscores.
Sorry for missing underline.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 3:
Can anyone review this issue please? Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#9).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/9
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 10:
Thank you for your help.
I have resolved the merger conflict through the following steps:
a.git remote add gerrit http://davidxdh@gerrit.cloudera.org:8080/Impala-ASF
b.git checkout -b gerrit_dev gerrit/master
c.modify the code and submit it with the original information as following:
git add *
git commit -m "***"
d.git push --no-thin gerrit HEAD:refs/for/master
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 8:
> I have tried to merge code, but IMPALA-5506 modified the same code.
> I don't know how to resolve it. Can you help me to merger code?
> Thanks.
I recommend https://help.github.com/articles/resolving-merge-conflicts-after-a-git-rebase/
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#2).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/2
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#5).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/5
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 12: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 8:
There are errors as follows when git push:
error: unpack failed: error Missing tree 72a38838092b37a5d0df2eb6cd3afbad419956f8
To http://davidxdh@gerrit.cloudera.org:8080/Impala-ASF
! [remote rejected] HEAD -> refs/for/master (n/a (unpacker error))
error: failed to push some refs to 'http://davidxdh@gerrit.cloudera.org:8080/Impala-ASF'
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 9:
Hi,Jim.I pull this patch by download the url, rebase it to master branch, then submit new code, but it doesn't resolve the conflict.
Would you please resolve the conflict please?
Thank you.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 9
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 12: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 6:
OK, looks good. If you rebase on the latest HEAD, I can push the change.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#4).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/4
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 8:
I have tried to merge code, but IMPALA-5506 modified the same code.
I don't know how to resolve it. Can you help me to merger code? Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 10: Verified-1
Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/832/
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#3).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/3
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#10).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/10
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7179/10/shell/option_parser.py
File shell/option_parser.py:
PS10, Line 88: "-",
Quotes inside quotes must be escaped using \.
When you do so, don't forget to keep the lines under 90 characters.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 10:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/832/
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 4:
(3 comments)
I have modified the code according to your opinion, please check again.
Thank you.
http://gerrit.cloudera.org:8080/#/c/7179/3/shell/option_parser.py
File shell/option_parser.py:
PS3, Line 88: rea
> "will"
Done
PS3, Line 162: follow th
> What exactly do you mean by character - do you mean a-z and A-Z?
Done
PS3, Line 163: KEY has
> What contains characters and/or numbers - KEY? VALUE?
Done
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7179/4/shell/option_parser.py
File shell/option_parser.py:
PS4, Line 88: Queries read from stdin and end with ctrl+d "
: "if the argument to -f is -.
Try "If the argument to -f is "-", then queries are read from stdin and terminated with ctrl-d."
PS4, Line 163: has character of a-z or A-Z at the beginning
"starts with an alphabetic character"
PS4, Line 164: characters of a-z or A-Z and/or numbers.
"only alphanumeric characters."
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 12:
Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/844/
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 12
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#6).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/6
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 6
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#8).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 7 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/8
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 8:
> There are errors as follows when git push:
> error: unpack failed: error Missing tree 72a38838092b37a5d0df2eb6cd3afbad419956f8
> To http://davidxdh@gerrit.cloudera.org:8080/Impala-ASF
> ! [remote rejected] HEAD -> refs/for/master (n/a (unpacker error))
> error: failed to push some refs to 'http://davidxdh@gerrit.cloudera.org:8080/Impala-ASF'
If you get stuck like this, you can use the Download button in the upper-right hand corner of this page to start again. It is best to do so from a fresh checkout of gerrit HEAD.
It would also be good to record, this next time you try, exactly which steps you took so you can copy-and-paste them here for diagnosis.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 8
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has uploaded a new patch set (#7).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/7
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 7
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Reviewed-on: http://gerrit.cloudera.org:8080/7179
Reviewed-by: Jim Apple <jb...@apache.org>
Tested-by: Impala Public Jenkins
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Jim Apple: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 13
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7179/5/shell/option_parser.py
File shell/option_parser.py:
Line 164: " contains only alphanumeric characters.")
This actually is incorrect - it can also contain underscores.
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 10
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 3:
(4 comments)
Thank you for sending this patch. A few comments:
http://gerrit.cloudera.org:8080/#/c/7179/3/shell/option_parser.py
File shell/option_parser.py:
PS3, Line 88: may
"will"
PS3, Line 88: stdin
Add back comment about ctrl+d?
PS3, Line 162: character
What exactly do you mean by character - do you mean a-z and A-Z?
PS3, Line 163: contains
What contains characters and/or numbers - KEY? VALUE?
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, Jim Apple,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7179
to look at the new patch set (#11).
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
IMPALA-5507: Add clear description to help information of KEYVAL option
Help information of KEYVAL option in impala-shell is not clear enough.
I fix this issue by adding clear description to help information of
KEYVAL option.
Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
---
M shell/option_parser.py
1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/79/7179/11
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 11
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option
Posted by "Donghui Xu (Code Review)" <ge...@cloudera.org>.
Donghui Xu has posted comments on this change.
Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option
......................................................................
Patch Set 5:
(3 comments)
I have solved the suggestion you have mentioned.
http://gerrit.cloudera.org:8080/#/c/7179/4/shell/option_parser.py
File shell/option_parser.py:
PS4, Line 88: If the argument to -f is "-", then queries are read from stdin"
: " and terminated with ctrl-d
> Try "If the argument to -f is "-", then queries are read from stdin and ter
Done
PS4, Line 163: starts with an alphabetic character and"
> "starts with an alphabetic character"
Done
PS4, Line 164: only alphanumeric characters.")
> "only alphanumeric characters."
Done
--
To view, visit http://gerrit.cloudera.org:8080/7179
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I68cfc16838c6c0e7813f03dd4296f9eb54ec4c63
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Donghui Xu <xu...@zte.com.cn>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-HasComments: Yes