You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Abraham Fine <ab...@abrahamfine.com> on 2016/04/12 01:40:00 UTC
Review Request 46063: SQOOP-2900
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-2900
https://issues.apache.org/jira/browse/SQOOP-2900
Repository: sqoop-sqoop2
Description
-------
Support encrypting map inputs with sensitive fields
Diffs
-----
common/src/main/java/org/apache/sqoop/error/code/CommonRepositoryError.java dd52c820a0c069e506863a34d5dbdcb0a2f903f0
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
core/src/main/java/org/apache/sqoop/driver/Driver.java 2d1d73ec27db3d24c100947ec982652b03fc4e9e
core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 44ab41b9575524456420993b062be9a40e91b829
core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 94f5e6f17beb0cdae8a5eebf1d8be6625aefc14e
core/src/main/java/org/apache/sqoop/repository/MasterKeyManager.java df84d540f8c6ede765709443ff4e2f5117f6847b
core/src/main/java/org/apache/sqoop/repository/Repository.java c2e3c749413296fa23ae90c1aac85440fcf7a2b1
core/src/main/java/org/apache/sqoop/security/SecurityError.java 2ba849c3abcc667e901aa4ec55d8c467316f1dee
core/src/test/java/org/apache/sqoop/repository/TestMasterKeyManager.java f9579bf3dc7b74149487f6a892792afe58a75e83
dist/src/main/conf/sqoop.properties 58b60fd192f3332dc7109ad7fc344ebb61e6e9a4
docs/src/site/sphinx/admin/Tools.rst 36fc231b5febc94d4860611e62d187bbac552df0
docs/src/site/sphinx/security/Encryption.rst 6471a07be46dc4c10e5ac40a0159d14fb9543b02
docs/src/site/sphinx/security/RepositoryEncryption.rst PRE-CREATION
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java a9168aee6379cb1b367e475d9bdc352be82aa482
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java d527290908131cda899f407ce439b77b9d167752
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaCreateQuery.java b4f66bb61e3112c66cdf8a6bed659262ff63a55e
test/pom.xml 4bac683d9497d7c6f24d1db4bd385efc3be566a3
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java c1a10bc32fc093b0a121bc4a2df363e3dbedd485
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java PRE-CREATION
tools/src/main/java/org/apache/sqoop/tools/tool/BuiltinTools.java 13a2c5f234840e422eb67db63d17645a865e23e9
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java PRE-CREATION
Diff: https://reviews.apache.org/r/46063/diff/
Testing
-------
Thanks,
Abraham Fine
Re: Review Request 46063: SQOOP-2900
Posted by Abraham Fine <ab...@abrahamfine.com>.
> On April 18, 2016, 8:50 p.m., Jarek Cecho wrote:
> > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java, lines 323-330
> > <https://reviews.apache.org/r/46063/diff/4/?file=1348704#file1348704line323>
> >
> > I understand the additional joins here, but is it intentional to get rid of the ORDER BY?
it was intentional. we never care about the order of the output from this query. it simply is not needed and i did not feel it worthy of another jira. let me know if you disagree.
- Abraham
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/#review129429
-----------------------------------------------------------
On April 18, 2016, 8:35 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46063/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 8:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2900
> https://issues.apache.org/jira/browse/SQOOP-2900
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Support encrypting map inputs with sensitive fields
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
>
> Diff: https://reviews.apache.org/r/46063/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 46063: SQOOP-2900
Posted by Jarek Cecho <ja...@apache.org>.
> On April 18, 2016, 8:50 p.m., Jarek Cecho wrote:
> > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java, lines 323-330
> > <https://reviews.apache.org/r/46063/diff/4/?file=1348704#file1348704line323>
> >
> > I understand the additional joins here, but is it intentional to get rid of the ORDER BY?
>
> Abraham Fine wrote:
> it was intentional. we never care about the order of the output from this query. it simply is not needed and i did not feel it worthy of another jira. let me know if you disagree.
Thanks for the quick answers. I know that we have several queries where the order actually matters, but this one seems to be used only on the encryption/decryption where the order indeed shouldn't matter.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/#review129429
-----------------------------------------------------------
On April 18, 2016, 8:35 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46063/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 8:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2900
> https://issues.apache.org/jira/browse/SQOOP-2900
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Support encrypting map inputs with sensitive fields
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
>
> Diff: https://reviews.apache.org/r/46063/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 46063: SQOOP-2900
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/#review129429
-----------------------------------------------------------
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java (lines 323 - 330)
<https://reviews.apache.org/r/46063/#comment192852>
I understand the additional joins here, but is it intentional to get rid of the ORDER BY?
Jarcec
- Jarek Cecho
On April 18, 2016, 8:35 p.m., Abraham Fine wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46063/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 8:35 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-2900
> https://issues.apache.org/jira/browse/SQOOP-2900
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Support encrypting map inputs with sensitive fields
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
> repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
> test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
> tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
>
> Diff: https://reviews.apache.org/r/46063/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Abraham Fine
>
>
Re: Review Request 46063: SQOOP-2900
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/
-----------------------------------------------------------
(Updated April 18, 2016, 8:35 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2900
https://issues.apache.org/jira/browse/SQOOP-2900
Repository: sqoop-sqoop2
Description
-------
Support encrypting map inputs with sensitive fields
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
Diff: https://reviews.apache.org/r/46063/diff/
Testing
-------
Thanks,
Abraham Fine
Re: Review Request 46063: SQOOP-2900
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/
-----------------------------------------------------------
(Updated April 12, 2016, 7:24 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2900
https://issues.apache.org/jira/browse/SQOOP-2900
Repository: sqoop-sqoop2
Description
-------
Support encrypting map inputs with sensitive fields
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
docs/src/site/sphinx/admin/Tools.rst 36fc231b5febc94d4860611e62d187bbac552df0
docs/src/site/sphinx/security/API TLS-SSL.rst PRE-CREATION
docs/src/site/sphinx/security/Encryption.rst 45ffc1787c7ade9a81efaf463baa89c8ed0c90e8
docs/src/site/sphinx/security/RepositoryEncryption.rst PRE-CREATION
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
Diff: https://reviews.apache.org/r/46063/diff/
Testing
-------
Thanks,
Abraham Fine
Re: Review Request 46063: SQOOP-2900
Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46063/
-----------------------------------------------------------
(Updated April 11, 2016, 11:56 p.m.)
Review request for Sqoop.
Bugs: SQOOP-2900
https://issues.apache.org/jira/browse/SQOOP-2900
Repository: sqoop-sqoop2
Description
-------
Support encrypting map inputs with sensitive fields
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/json/util/ConfigInputSerialization.java 4ce977cf43822314c4d34b0fb48ceffd80eb9bd8
docs/src/site/sphinx/admin/Tools.rst 36fc231b5febc94d4860611e62d187bbac552df0
docs/src/site/sphinx/security/API TLS-SSL.rst PRE-CREATION
docs/src/site/sphinx/security/Encryption.rst 45ffc1787c7ade9a81efaf463baa89c8ed0c90e8
docs/src/site/sphinx/security/RepositoryEncryption.rst PRE-CREATION
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java 4cae8113b2a935cc294922108f8c573e5f090513
repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java 91187225c3cecf69727e32ab40df41138faa86cd
test/src/test/java/org/apache/sqoop/integration/tools/RepositoryEncryptionToolTest.java 5f588f5ac167bf0f1f4309deafe655653528b36e
tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryEncryptionTool.java d0eab40c4a83c8c536c0af26bd91565d49f2661c
Diff: https://reviews.apache.org/r/46063/diff/
Testing
-------
Thanks,
Abraham Fine