You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2025/12/04 09:05:25 UTC
Re: [PR] GH-48220: [C++] Fix arrow-buffer & arrow-misc testcase failures on s390x [arrow]
zanmato1984 commented on code in PR #48221:
URL: https://github.com/apache/arrow/pull/48221#discussion_r2588157464
##########
cpp/src/arrow/buffer_test.cc:
##########
@@ -996,7 +997,8 @@ TYPED_TEST(TypedTestBuffer, TypedResize) {
TYPED_TEST(TypedTestBuffer, ResizeOOM) {
// This test doesn't play nice with AddressSanitizer
-#ifndef ADDRESS_SANITIZER
+// Skip this test on big-endian architectures (e.g., s390x)
+#if !defined(ADDRESS_SANITIZER) && ARROW_LITTLE_ENDIAN
Review Comment:
Same concern. It's not obvious why this test won't work on big-endian so a brief explanation would help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org