You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2011/08/17 16:15:27 UTC
[jira] [Created] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Verifification of unique client ID does not work in Java Broker
---------------------------------------------------------------
Key: QPID-3428
URL: https://issues.apache.org/jira/browse/QPID-3428
Project: Qpid
Issue Type: Bug
Components: Java Broker, Java Client
Affects Versions: 0.10
Reporter: Alex Rudyy
Assignee: Robbie Gemmell
Priority: Minor
On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
"The client should throw a ConnectionException stating the client ID is not unique"
junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Closed] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell closed QPID-3428.
--------------------------------
Resolution: Fixed
Updated to prevent the duplicate 0-10 ServerSession creations + registrations.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3428:
---------------------------------
Summary: Verification of unique client ID does not work with Java Broker (was: Verifification of unique client ID does not work in Java Broker)
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3428:
------------------------------------
Assignee: Robbie Gemmell (was: Andrew MacBean)
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3428:
------------------------------------
Assignee: Robbie Gemmell (was: Andrew MacBean)
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3428:
---------------------------------
Attachment: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3428:
---------------------------------
Assignee: Andrew MacBean (was: Robbie Gemmell)
Status: Open (was: Ready To Review)
Changes look good overall, but theres a some bits I think could be improved:
In ServerConnectionDelegate.sessionAttach, the clientId (sessionName, rather?) variable can never be null so the check is redundant.Also, in the new 'isSessionNameUnique' method, we can probably be mroe efficient than iterating over every Session in the broker and comparing ClientIDs. Each Connection object has a Map of session names to their Session, so it should be possible to just ask query connection whether it has a Session with a given name, with the 0-8/9/9-1 connections simply returning false since they dont support that.
In AMQConnectionDelegate / AMQConnection, it seems like it would be better to use a boolean for the result normally and rethrow any unexpected exceptions, rather than detecting whether or not there is a linked exception set to distinguish between two JMSExceptions.
Finally, in ConnectionTest you could use the setTestSystemProperty() method from QpidTestCase method to update and revert the 'qpid.verify_client_id' property (which should probably be a constant; there should be one in ClientProperties, but if there isnt it needs added).
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3428:
---------------------------------
Attachment: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
Review comments actioned, please review.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Reopened] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reopened QPID-3428:
----------------------------------
Reopening, investigation of an apparent memory leak has shown the previous changes result in leaking the sessions+connections in the management layer by causing duplicate registrations to occur.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Reopened] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reopened QPID-3428:
----------------------------------
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3428:
---------------------------------
Attachment: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
Checked this vs the C++ broker and you were right, modified the patch and added a new test to highlight the difference.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3428:
------------------------------------
Assignee: Andrew MacBean (was: Robbie Gemmell)
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3428:
---------------------------------
Status: Ready To Review (was: In Progress)
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3428:
---------------------------------
Fix Version/s: 0.13
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean reassigned QPID-3428:
------------------------------------
Assignee: Robbie Gemmell (was: Andrew MacBean)
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3428) Verification of unique client ID
does not work with Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102543#comment-13102543 ]
Robbie Gemmell commented on QPID-3428:
--------------------------------------
Looks good, but I missed something in my original review that still needs addressed. The 0-10 session naming should be per-principal, so currently the verification being done is too strict in that it checks only if the name exists, not whether it is for the same principal, so we need to relax that accordingly.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3428.
----------------------------------
Resolution: Fixed
Patch applied, along with a fix for the excludes file and some small test tweaks.
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker3.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean updated QPID-3428:
---------------------------------
Status: Ready To Review (was: In Progress)
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3428) Verification of unique client ID does
not work with Java Broker
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3428:
------------------------------------
Assignee: Andrew MacBean (was: Robbie Gemmell)
> Verification of unique client ID does not work with Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Andrew MacBean
> Priority: Minor
> Fix For: 0.13
>
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch, [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker2.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095213#comment-13095213 ]
Andrew MacBean commented on QPID-3428:
--------------------------------------
Based on test case and implementation in Java client and C++ broker for (QPID-3269) the broker has been changed to validate that the client id used is unique when creating a new session and attaching.
If the client id is null or is unique then the session is attached as before, otherwise it invokes session detached and sets the session detach code to SESSION_BUSY and calls session.closed().
A patch has been attached for review. The patch also includes some minor client changes to fix a small bug found during development in the Session.awaitOpen() method which was throwing a SessionException even if the state was OPEN as expected. This was "swallowed" later so had no real knock on effect anyway.
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3428) Verifification of unique client ID
does not work in Java Broker
Posted by "Andrew MacBean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew MacBean resolved QPID-3428.
----------------------------------
Resolution: Fixed
Robbie, could you please review the attached patch and apply if suitable.
Thanks
Andrew
> Verifification of unique client ID does not work in Java Broker
> ---------------------------------------------------------------
>
> Key: QPID-3428
> URL: https://issues.apache.org/jira/browse/QPID-3428
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker, Java Client
> Affects Versions: 0.10
> Reporter: Alex Rudyy
> Assignee: Robbie Gemmell
> Priority: Minor
> Attachments: [QPID-3428]-verifification-of-unique-client-ID-does-not-work-in-Java-Broker.patch
>
>
> On settings client JVM property "qpid.verify_client_id" to "true" Qpid broker should not allow creation of connections with the same client id. However, this functionality does not work at the moment.
> JUnit test org.apache.qpid.test.unit.client.connection.ConnectionTest#testClientIDVerification fails with the following message:
> "The client should throw a ConnectionException stating the client ID is not unique"
> junit.framework.AssertionFailedError: The client should throw a ConnectionException stating the client ID is not unique
> at org.apache.qpid.test.unit.client.connection.ConnectionTest.testClientIDVerification(ConnectionTest.java:307)
> at org.apache.qpid.test.utils.QpidBrokerTestCase.runBare(QpidBrokerTestCase.java:243)
> at org.apache.qpid.test.utils.QpidTestCase.run(QpidTestCase.java:125)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org