You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/09 19:57:18 UTC
[GitHub] [hive] kishendas opened a new pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
kishendas opened a new pull request #2465:
URL: https://github.com/apache/hive/pull/2465
### Why are the changes needed?
Advance Write ID during AlterTableDropPartition DDL
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kishendas commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
kishendas commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-886342605
@nrg4878 One unrelated test is failing now http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2465/12/tests . Please commit this change, whenever you get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #2465:
URL: https://github.com/apache/hive/pull/2465
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] hsnusonic commented on a change in pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
hsnusonic commented on a change in pull request #2465:
URL: https://github.com/apache/hive/pull/2465#discussion_r670660542
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
##########
@@ -105,11 +106,18 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition
AlterTableDropPartitionDesc desc =
new AlterTableDropPartitionDesc(tableName, partitionSpecs, mustPurge, replicationSpec);
+
+ Task<DDLWork> ddlTask = TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc));
Review comment:
Is `ddlTask` used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] nrg4878 commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
nrg4878 commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-887529268
fix has been committed to master. Please close the PR. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-974730548
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kishendas commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
kishendas commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-881494520
It's failing during "Archiving" stage with below error, which seems to be intermittent. Hopefully I will get a green run in the next one.
[2021-07-15T06:00:07.621Z] java.net.ProtocolException: Expected HTTP 101 response but was '500 Internal Server Error'
[2021-07-15T06:00:07.621Z] at okhttp3.internal.ws.RealWebSocket.checkResponse(RealWebSocket.java:229)
[2021-07-15T06:00:07.621Z] at okhttp3.internal.ws.RealWebSocket$2.onResponse(RealWebSocket.java:196)
[2021-07-15T06:00:07.621Z] at okhttp3.RealCall$AsyncCall.execute(RealCall.java:203)
[2021-07-15T06:00:07.621Z] at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
[2021-07-15T06:00:07.621Z] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2021-07-15T06:00:07.621Z] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2021-07-15T06:00:07.621Z] at java.lang.Thread.run(Thread.java:748)
io.fabric8.kubernetes.client.KubernetesClientException: error dialing backend: EOF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kishendas commented on a change in pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
kishendas commented on a change in pull request #2465:
URL: https://github.com/apache/hive/pull/2465#discussion_r671300633
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/partition/drop/AbstractDropPartitionAnalyzer.java
##########
@@ -105,11 +106,18 @@ protected void analyzeCommand(TableName tableName, Map<String, String> partition
AlterTableDropPartitionDesc desc =
new AlterTableDropPartitionDesc(tableName, partitionSpecs, mustPurge, replicationSpec);
+
+ Task<DDLWork> ddlTask = TaskFactory.get(new DDLWork(getInputs(), getOutputs(), desc));
Review comment:
Not used. Fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-974730548
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sourabh912 commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
sourabh912 commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-881480860
Looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kishendas commented on pull request #2465: HIVE-25321: advance write id during AlterTableDropPartition
Posted by GitBox <gi...@apache.org>.
kishendas commented on pull request #2465:
URL: https://github.com/apache/hive/pull/2465#issuecomment-887232500
@nrg4878 Got a green build -> http://ci.hive.apache.org/blue/organizations/jenkins/hive-precommit/detail/PR-2465/13/pipeline/ .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org