[jira] [Commented] (ARROW-16847) [C++] Rename or fix compute/kernels/aggregate_{mode, quantile}.cc modules to actually be aggregate functions

["Yibo Cai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-16847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555395#comment-17555395 ] 

Yibo Cai commented on ARROW-16847:
----------------------------------

Looks to me these two functions are a bit special.

Mode kernel was an aggregate kernel but refactored due to performance issue caused by large state [1].
Quantile depends on all inputs, cannot be merged.

[1] https://github.com/apache/arrow/pull/10009

> [C++] Rename or fix compute/kernels/aggregate_{mode, quantile}.cc modules to actually be aggregate functions
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: ARROW-16847
>                 URL: https://issues.apache.org/jira/browse/ARROW-16847
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 9.0.0
>
>
> These modules import VectorFunctions even though their file names state otherwise. Either they should implement aggregate functions or the files should be renamed to indicate that they are vector functions



--
This message was sent by Atlassian Jira
(v8.20.7#820007)