You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by ma...@apache.org on 2016/10/27 01:03:36 UTC

spark git commit: [SPARK-17770][CATALYST] making ObjectType public

Repository: spark
Updated Branches:
  refs/heads/master 5b27598ff -> f1aeed8b0


[SPARK-17770][CATALYST] making ObjectType public

## What changes were proposed in this pull request?

In order to facilitate the writing of additional Encoders, I proposed opening up the ObjectType SQL DataType. This DataType is used extensively in the JavaBean Encoder, but would also be useful in writing other custom encoders.

As mentioned by marmbrus, it is understood that the Expressions API is subject to potential change.

## How was this patch tested?

The change only affects the visibility of the ObjectType class, and the existing SQL test suite still runs without error.

Author: ALeksander Eskilson <al...@cerner.com>

Closes #15453 from bdrillard/master.


Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/f1aeed8b
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/f1aeed8b
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/f1aeed8b

Branch: refs/heads/master
Commit: f1aeed8b022e043de2eb38b30187dcc36ee8dcdb
Parents: 5b27598
Author: ALeksander Eskilson <al...@cerner.com>
Authored: Wed Oct 26 18:03:31 2016 -0700
Committer: Michael Armbrust <mi...@databricks.com>
Committed: Wed Oct 26 18:03:31 2016 -0700

----------------------------------------------------------------------
 .../scala/org/apache/spark/sql/types/ObjectType.scala   | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/spark/blob/f1aeed8b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala
----------------------------------------------------------------------
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala
index c741a2d..b18fba2 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/types/ObjectType.scala
@@ -19,7 +19,10 @@ package org.apache.spark.sql.types
 
 import scala.language.existentials
 
-private[sql] object ObjectType extends AbstractDataType {
+import org.apache.spark.annotation.InterfaceStability
+
+@InterfaceStability.Evolving
+object ObjectType extends AbstractDataType {
   override private[sql] def defaultConcreteType: DataType =
     throw new UnsupportedOperationException("null literals can't be casted to ObjectType")
 
@@ -32,11 +35,10 @@ private[sql] object ObjectType extends AbstractDataType {
 }
 
 /**
- * Represents a JVM object that is passing through Spark SQL expression evaluation.  Note this
- * is only used internally while converting into the internal format and is not intended for use
- * outside of the execution engine.
+ * Represents a JVM object that is passing through Spark SQL expression evaluation.
  */
-private[sql] case class ObjectType(cls: Class[_]) extends DataType {
+@InterfaceStability.Evolving
+case class ObjectType(cls: Class[_]) extends DataType {
   override def defaultSize: Int = 4096
 
   def asNullable: DataType = this


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org