You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by "bossenti (via GitHub)" <gi...@apache.org> on 2023/02/12 16:45:59 UTC
Re: [PR] [#1040] rework schema definitions in geo processors (streampipes)
bossenti commented on code in PR #1268:
URL: https://github.com/apache/streampipes/pull/1268#discussion_r1103833478
##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/trajectory/TrajectoryFromPointsProcessor.java:
##########
@@ -51,8 +51,9 @@ public class TrajectoryFromPointsProcessor extends StreamPipesDataProcessor {
private static final String SUBPOINTS_KEY = "subpoints-key";
private static final String DESCRIPTION_KEY = "description-key";
private static final String TRAJECTORY_KEY = "trajectory-key";
- private static final String TRAJECTORY_RUNTIME = "trajectoryWKT";
- private static final String DESCRIPTION_RUNTIME = "trajectoryDescription";
+ private static final String TRAJECTORY_GEOMETRY_RUNTIME = "trajectory-geometry";
+ private static final String TRAJECTORY_EPSG_RUNTIME = "trajectory-epsg";
+ private static final String DESCRIPTION_RUNTIME = "trajectory-description";
Review Comment:
Do you not want to provide labels via the `strings.en` file?
##########
streampipes-extensions/streampipes-processors-geo-jvm/src/main/java/org/apache/streampipes/processors/geo/jvm/jts/processor/latlngtojtspoint/LatLngToJtsPointProcessor.java:
##########
@@ -101,7 +101,11 @@ public void onEvent(Event event, SpOutputCollector collector) throws SpRuntimeEx
Point geom = SpGeometryBuilder.createSPGeom(lng, lat, epsg);
if (!geom.isEmpty()) {
- event.addField(WKT_RUNTIME, geom.toString());
+ // if activated the stream fails at all
+ //event.removeFieldBySelector(latitudeMapper);
+ //event.removeFieldBySelector(longitudeMapper);
Review Comment:
Can we please refrain from committing dead code? :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org