[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #2524: Increase the major version for php.editor

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #2524:
URL: https://github.com/apache/netbeans/pull/2524#discussion_r518610327



##########
File path: php/php.dbgp/nbproject/project.xml
##########
@@ -171,7 +171,7 @@
                     <build-prerequisite/>
                     <compile-dependency/>
                     <run-dependency>
-                        <specification-version>1.2</specification-version>

Review comment:
       I would start with:
   ```
   diff --git a/php/php.editor/manifest.mf b/php/php.editor/manifest.mf
   index 9e9be53ff210..9509c51eab9a 100644
   --- a/php/php.editor/manifest.mf
   +++ b/php/php.editor/manifest.mf
   @@ -1,6 +1,6 @@
    Manifest-Version: 1.0
    AutoUpdate-Show-In-Client: false
   -OpenIDE-Module: org.netbeans.modules.php.editor
   +OpenIDE-Module: org.netbeans.modules.php.editor/2
    OpenIDE-Module-Layer: org/netbeans/modules/php/editor/resources/layer.xml
    OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/php/editor/resources/Bundle.properties
    OpenIDE-Module-Implementation-Version: 2
   diff --git a/php/php.editor/nbproject/project.properties b/php/php.editor/nbproject/project.properties
   index a7de1b9d9229..160762e689b5 100644
   --- a/php/php.editor/nbproject/project.properties
   +++ b/php/php.editor/nbproject/project.properties
   @@ -20,7 +20,7 @@ build.compiler=extJavac
    nbjavac.ignore.missing.enclosing=**/CUP$ASTPHP5Parser$actions.class
    javac.compilerargs=-J-Xmx512m
    nbm.needs.restart=true
   -spec.version.base=1.89.0
   +spec.version.base=2.0
    release.external/predefined_vars-1.0.zip=docs/predefined_vars.zip
    sigtest.gen.fail.on.error=false
   ```
   which would then require this change to be:
   ```
   --- a/php/php.dbgp/nbproject/project.xml
   +++ b/php/php.dbgp/nbproject/project.xml
   @@ -171,7 +171,8 @@
                        <build-prerequisite/>
                        <compile-dependency/>
                        <run-dependency>
   -                        <specification-version>1.2</specification-version>
   +                        <release-version>2</release-version>
   +                        <specification-version>2.0</specification-version>
                        </run-dependency>
                    </dependency>
                    <dependency>
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists