You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/08/17 05:41:15 UTC

[GitHub] zeppelin pull request #1337: [ZEPPELIN-1333] Fix Double Run when Shift + Ent...

GitHub user corneadoug opened a pull request:

    https://github.com/apache/zeppelin/pull/1337

    [ZEPPELIN-1333] Fix Double Run when Shift + Enter on display form

    ### What is this PR for?
    Display form input has a `ng-enter` catcher, so if you use SHIFT + ENTER, the run function will be called twice.
    This PR is resolving the issue by removing the `ng-enter`, making the display form input react to SHIT + ENTER only.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1333
    
    ### How should this be tested?
    I used 3 different paragraphs:
    ```
    %spark 
    var counter=0;
    def myTestFunc(testVal:Int) = {
        counter+=testVal;
        println(s"$counter");
    }
    ```
    
    ```
    %spark 
    myTestFunc(1);
    ```
    
    ```
    %spark 
    myTestFunc(z.input("testvalue").toString().toInt);
    ```
    
    Both paragraph 2 and 3 should increment of 1 (type 1 in the input).
    The input in Paragraph 3 should be ran only with SHIFT + ENTER
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? In a way yes
    * Does this needs documentation? Good question


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1333

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1337.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1337
    
----
commit 09e20df88693c96b3a1e55e12e1670082d94a4f5
Author: Damien CORNEAU <co...@gmail.com>
Date:   2016-08-17T05:32:21Z

    remove ng-enter from dynamic form input

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1337: [ZEPPELIN-1333] Fix Double Run when Shift + Enter on d...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:

    https://github.com/apache/zeppelin/pull/1337
  
    Closing in favor of #1336 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1337: [ZEPPELIN-1333] Fix Double Run when Shift + Ent...

Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:

    https://github.com/apache/zeppelin/pull/1337


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---