You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2018/06/06 08:43:03 UTC
Re: Review Request 66561: Supported hdfs fetching in local puller.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66561/
-----------------------------------------------------------
(Updated June 6, 2018, 1:43 a.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794
Repository: mesos
Description
-------
Supported hdfs fetching in local puller.
Diffs (updated)
-----
docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/hdfs/hdfs.hpp 716d13ff905e937f991f0a997e4d3cdca3b6e521
src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174
src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 4d2e4973a0d6c99dd3447a158003b4b09e2ba477
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 509be63635e21e48a62deaf7c545575d2d8221b3
src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951
src/slave/containerizer/mesos/provisioner/docker/store.cpp f6b8f394ee83d15b74bb0a100d768b9b32235734
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/66561/diff/3/
Changes: https://reviews.apache.org/r/66561/diff/2-3/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 66561: Supported hdfs fetching in local puller.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66561/
-----------------------------------------------------------
(Updated June 6, 2018, 10:14 a.m.)
Review request for mesos, Jie Yu and Qian Zhang.
Bugs: MESOS-8794
https://issues.apache.org/jira/browse/MESOS-8794
Repository: mesos
Description
-------
Supported hdfs fetching in local puller.
Diffs (updated)
-----
docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
src/hdfs/hdfs.hpp 716d13ff905e937f991f0a997e4d3cdca3b6e521
src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174
src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 4d2e4973a0d6c99dd3447a158003b4b09e2ba477
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 509be63635e21e48a62deaf7c545575d2d8221b3
src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951
src/slave/containerizer/mesos/provisioner/docker/store.cpp f6b8f394ee83d15b74bb0a100d768b9b32235734
src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
Diff: https://reviews.apache.org/r/66561/diff/4/
Changes: https://reviews.apache.org/r/66561/diff/3-4/
Testing
-------
make check
Thanks,
Gilbert Song
Re: Review Request 66561: Supported hdfs fetching in local puller.
Posted by Gilbert Song <so...@gmail.com>.
> On June 6, 2018, 8:57 a.m., Qian Zhang wrote:
> > docs/configuration/agent.md
> > Line 626 (original), 626 (patched)
> > <https://reviews.apache.org/r/66561/diff/3/?file=2036021#file2036021line626>
> >
> > s/a HDFS/an HDFS/
+1
> On June 6, 2018, 8:57 a.m., Qian Zhang wrote:
> > docs/configuration/agent.md
> > Line 627 (original), 627 (patched)
> > <https://reviews.apache.org/r/66561/diff/3/?file=2036021#file2036021line627>
> >
> > It seems "). Note " is missed between "</code>" and "that".
good catch
> On June 6, 2018, 8:57 a.m., Qian Zhang wrote:
> > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp
> > Lines 107-112 (patched)
> > <https://reviews.apache.org/r/66561/diff/3/?file=2036025#file2036025line107>
> >
> > Can we just merge these 4 lines into `return HDFS::parse(uri)`?
dang..my mistake!!!!
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66561/#review204397
-----------------------------------------------------------
On June 6, 2018, 1:43 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66561/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 1:43 a.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported hdfs fetching in local puller.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
> src/hdfs/hdfs.hpp 716d13ff905e937f991f0a997e4d3cdca3b6e521
> src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174
> src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 4d2e4973a0d6c99dd3447a158003b4b09e2ba477
> src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 509be63635e21e48a62deaf7c545575d2d8221b3
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f6b8f394ee83d15b74bb0a100d768b9b32235734
> src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
>
>
> Diff: https://reviews.apache.org/r/66561/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 66561: Supported hdfs fetching in local puller.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66561/#review204397
-----------------------------------------------------------
Fix it, then Ship it!
docs/configuration/agent.md
Line 626 (original), 626 (patched)
<https://reviews.apache.org/r/66561/#comment286890>
s/a HDFS/an HDFS/
docs/configuration/agent.md
Line 627 (original), 627 (patched)
<https://reviews.apache.org/r/66561/#comment286893>
It seems "). Note " is missed between "</code>" and "that".
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp
Lines 107-112 (patched)
<https://reviews.apache.org/r/66561/#comment286904>
Can we just merge these 4 lines into `return HDFS::parse(uri)`?
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp
Lines 128 (patched)
<https://reviews.apache.org/r/66561/#comment286905>
Suggest to change "Failed to parse URI: " to "Failed to parse the agent flag `--docker_registry`: "
src/slave/containerizer/mesos/provisioner/docker/puller.cpp
Lines 44 (patched)
<https://reviews.apache.org/r/66561/#comment286906>
s/either pulling from/pulling from either/
src/slave/flags.cpp
Line 205 (original), 205 (patched)
<https://reviews.apache.org/r/66561/#comment286891>
Ditto.
src/slave/flags.cpp
Lines 206 (patched)
<https://reviews.apache.org/r/66561/#comment286894>
Ditto.
- Qian Zhang
On June 6, 2018, 4:43 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66561/
> -----------------------------------------------------------
>
> (Updated June 6, 2018, 4:43 p.m.)
>
>
> Review request for mesos, Jie Yu and Qian Zhang.
>
>
> Bugs: MESOS-8794
> https://issues.apache.org/jira/browse/MESOS-8794
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Supported hdfs fetching in local puller.
>
>
> Diffs
> -----
>
> docs/configuration/agent.md e0aaf2c15023d1cb24e16b02f948b3d3848be57a
> src/hdfs/hdfs.hpp 716d13ff905e937f991f0a997e4d3cdca3b6e521
> src/hdfs/hdfs.cpp 726925fbe2cbca1fbffb213eebb8de0cca815174
> src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 4d2e4973a0d6c99dd3447a158003b4b09e2ba477
> src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 509be63635e21e48a62deaf7c545575d2d8221b3
> src/slave/containerizer/mesos/provisioner/docker/puller.cpp d7d8987d493a37d20f32ddd254dc0c3b15159951
> src/slave/containerizer/mesos/provisioner/docker/store.cpp f6b8f394ee83d15b74bb0a100d768b9b32235734
> src/slave/flags.cpp 23d9bb1ca9bc7451afae69f39c25605660612c2e
>
>
> Diff: https://reviews.apache.org/r/66561/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Gilbert Song
>
>