You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@avro.apache.org by GitBox <gi...@apache.org> on 2022/02/14 22:49:19 UTC

[GitHub] [avro] KyleSchoonover edited a comment on pull request #1549: AVRO-3402 Updated GenericWriter to meet style guidelines

KyleSchoonover edited a comment on pull request #1549:
URL: https://github.com/apache/avro/pull/1549#issuecomment-1039650500


   `if (o1 is IDictionary)
   vs
   if (left is Array leftArray)`
   
   This is actually the recommended way to avoid additional casting.  Not only a styling thing, but a performance improvement.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org