You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by sv...@apache.org on 2014/06/04 17:59:52 UTC
git commit: WICKET-5606 improved javadoc for setRecreateChoices()
Repository: wicket
Updated Branches:
refs/heads/wicket-6.x 35c80feb0 -> 8391dcf91
WICKET-5606 improved javadoc for setRecreateChoices()
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/8391dcf9
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/8391dcf9
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/8391dcf9
Branch: refs/heads/wicket-6.x
Commit: 8391dcf91f791dda2cd616e02100892fb76f0a5a
Parents: 35c80fe
Author: svenmeier <sv...@meiers.net>
Authored: Wed Jun 4 17:59:08 2014 +0200
Committer: svenmeier <sv...@meiers.net>
Committed: Wed Jun 4 17:59:08 2014 +0200
----------------------------------------------------------------------
.../extensions/markup/html/form/select/SelectOptions.java | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/8391dcf9/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
index 8116615..6cf60d6 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/select/SelectOptions.java
@@ -78,10 +78,16 @@ public class SelectOptions<T> extends RepeatingView
}
/**
- * Controls whether or not SelectChoice objects are recreated every request
+ * Controls whether {@link SelectOption}s are recreated on every request
+ * <p>
+ * Note: When refreshing on each render, {@link #newOption(String, IModel)} should return
+ * {@link SelectOption}s with stable values, otherwise the current selection will be lost on
+ * form errors.
*
* @param refresh
* @return this for chaining
+ *
+ * @see SelectOption#getValue()
*/
public SelectOptions<T> setRecreateChoices(final boolean refresh)
{