You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by lu...@apache.org on 2009/09/04 00:48:34 UTC
svn commit: r811162 - in /myfaces/core/trunk:
api/src/main/java/javax/faces/component/UIViewParameter.java
impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
Author: lu4242
Date: Thu Sep 3 22:48:34 2009
New Revision: 811162
URL: http://svn.apache.org/viewvc?rev=811162&view=rev
Log:
MYFACES-2345 Add View Parameters feature (cleanup and add TODO)
Modified:
myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewParameter.java
myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewParameter.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewParameter.java?rev=811162&r1=811161&r2=811162&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewParameter.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIViewParameter.java Thu Sep 3 22:48:34 2009
@@ -23,7 +23,6 @@
import javax.el.ValueExpression;
import javax.faces.FactoryFinder;
import javax.faces.application.FacesMessage;
-import javax.faces.component.UIForm.PropertyKeys;
import javax.faces.context.FacesContext;
import javax.faces.convert.Converter;
import javax.faces.convert.ConverterException;
Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java?rev=811162&r1=811161&r2=811162&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/FaceletViewDeclarationLanguage.java Thu Sep 3 22:48:34 2009
@@ -1642,8 +1642,14 @@
// FIXME: spec doesn't say that this is necessary, but we blow up later if
// the viewroot isn't available from the FacesContext.
-
context.setViewRoot(view);
+
+ // TODO: -= Leonardo Uribe =- This part is related to section 2.5.5 of jsf 2.0 spec.
+ // In theory what we need here is fill UIViewRoot.METADATA_FACET_NAME facet
+ // with UIViewParameter instances. Later, ViewHandlerImpl.getBookmarkableURL(),
+ // ViewHandlerImpl.getRedirectURL() and UIViewRoot.encodeEnd uses them.
+ // For now, the only way to do this is call buildView(context,view) method, but
+ // this is a waste of resources. We need to find another way to handle facelets view metadata.
buildView(context, view);
return view;