You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/25 02:46:08 UTC
[GitHub] [kafka] guozhangwang opened a new pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response
guozhangwang opened a new pull request #8548:
URL: https://github.com/apache/kafka/pull/8548
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#issuecomment-619308603
@ableegoldman @hachikuji
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] guozhangwang commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response
Posted by GitBox <gi...@apache.org>.
guozhangwang commented on pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#issuecomment-620300754
test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on a change in pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on a change in pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#discussion_r415991034
##########
File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java
##########
@@ -1231,13 +1235,13 @@ public void handle(OffsetCommitResponse commitResponse, RequestFuture<Void> futu
// only need to reset generation and re-join group if generation has not changed;
// otherwise only raise rebalance-in-progress error
Review comment:
Should we update the comment here (and on line 1205)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #8548: KAFKA-9823: Follow-up, check state for handling commit error response
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #8548:
URL: https://github.com/apache/kafka/pull/8548#issuecomment-620144298
Flaky test failures:
`QueryableStateIntegrationTest.shouldAllowConcurrentAccesses`
`ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`
`OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org