You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Honghai Chen <ho...@microsoft.com> on 2015/06/19 07:55:04 UTC

Re: Review Request 33204: Patch for KAFKA-1646 Fix2TestCasesAndLogClean

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------

(Updated June 19, 2015, 5:55 a.m.)


Review request for kafka.


Summary (updated)
-----------------

Patch for KAFKA-1646 Fix2TestCasesAndLogClean


Bugs: KAFKA-1646
    https://issues.apache.org/jira/browse/KAFKA-1646


Repository: kafka


Description (updated)
-------

Kafka 1646 Fix2TestCasesAndLogClean


Diffs (updated)
-----

  core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503 
  core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 
  core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9 
  core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3 
  core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631 
  core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88 
  core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 
  core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06 
  core/src/test/resources/log4j.properties 1b7d5d8f7d5fae7d272849715714781cad05d77b 
  core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056 
  core/src/test/scala/unit/kafka/log/LogConfigTest.scala f3546adee490891e0d8d0214bef00b1dd7f42227 
  core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942 
  core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala ace6321b36d809946554d205bc926c9c76a43bd6 

Diff: https://reviews.apache.org/r/33204/diff/


Testing
-------


Thanks,

Honghai Chen


Re: Review Request 33204: Improve 1646 fix by add log.preallocate

Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------

(Updated June 19, 2015, 6:53 a.m.)


Review request for kafka.


Bugs: KAFKA-1646
    https://issues.apache.org/jira/browse/KAFKA-1646


Repository: kafka


Description (updated)
-------

Kafka 1646 fix 2 test cases and log clean and merge to latest


Diffs (updated)
-----

  core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503 
  core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 
  core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9 
  core/src/main/scala/kafka/log/LogConfig.scala e9af221299895d8b492438e8a0d0f2bbbd03fb3c 
  core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631 
  core/src/main/scala/kafka/server/KafkaConfig.scala e0b248020c7f6b3f3e7305b688faea68e12bb31c 
  core/src/main/scala/kafka/server/KafkaServer.scala 9de2a6f49083ff34261c5a783aaddf56a7a04ce1 
  core/src/main/scala/kafka/utils/CoreUtils.scala f5d704c5a702d14c85fae31eaa34b450b60b4597 
  core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056 
  core/src/test/scala/unit/kafka/log/LogConfigTest.scala c31f8841bbbd3e70b77428d4a5784a02e56c651b 
  core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942 
  core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala 826885298fbcfe6de1e3cae16fd85677991a540f 

Diff: https://reviews.apache.org/r/33204/diff/


Testing
-------


Thanks,

Honghai Chen


Re: Review Request 33204: Improve 1646 fix by add log.preallocate

Posted by Honghai Chen <ho...@microsoft.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33204/
-----------------------------------------------------------

(Updated June 19, 2015, 5:56 a.m.)


Review request for kafka.


Summary (updated)
-----------------

Improve 1646 fix by add log.preallocate


Bugs: KAFKA-1646
    https://issues.apache.org/jira/browse/KAFKA-1646


Repository: kafka


Description
-------

Kafka 1646 Fix2TestCasesAndLogClean


Diffs (updated)
-----

  core/src/main/scala/kafka/log/FileMessageSet.scala 2522604bd985c513527fa0c863a7df677ff7a503 
  core/src/main/scala/kafka/log/Log.scala 84e7b8fe9dd014884b60c4fbe13c835cf02a40e4 
  core/src/main/scala/kafka/log/LogCleaner.scala c9ade7208798fbd92d4ff49e183fe5f8925c82a9 
  core/src/main/scala/kafka/log/LogConfig.scala a907da09e1ccede3b446459225e407cd1ae6d8b3 
  core/src/main/scala/kafka/log/LogSegment.scala ed039539ac18ea4d65144073915cf112f7374631 
  core/src/main/scala/kafka/server/KafkaConfig.scala 2d75186a110075e0c322db4b9f7a8c964a7a3e88 
  core/src/main/scala/kafka/server/KafkaServer.scala b320ce9f6a12c0ee392e91beb82e8804d167f9f4 
  core/src/main/scala/kafka/utils/CoreUtils.scala d0a8fa701564b4c13b3cd6501e1b6218d77e8e06 
  core/src/test/resources/log4j.properties 1b7d5d8f7d5fae7d272849715714781cad05d77b 
  core/src/test/scala/unit/kafka/log/FileMessageSetTest.scala cec1caecc51507ae339ebf8f3b8a028b12a1a056 
  core/src/test/scala/unit/kafka/log/LogConfigTest.scala f3546adee490891e0d8d0214bef00b1dd7f42227 
  core/src/test/scala/unit/kafka/log/LogSegmentTest.scala 03fb3512c4a4450eac83d4cd4b0919baeaa22942 
  core/src/test/scala/unit/kafka/server/KafkaConfigConfigDefTest.scala ace6321b36d809946554d205bc926c9c76a43bd6 

Diff: https://reviews.apache.org/r/33204/diff/


Testing
-------


Thanks,

Honghai Chen