You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by xhochy <gi...@git.apache.org> on 2016/11/09 12:03:26 UTC
[GitHub] drill pull request #649: DRILL-4979: Make port of the DataConnection configu...
GitHub user xhochy opened a pull request:
https://github.com/apache/drill/pull/649
DRILL-4979: Make port of the DataConnection configurable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/xhochy/drill DRILL-4979
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #649
----
commit 277b14f552bb8cff001fd251bd3bc5303bf9e8b4
Author: Korn, Uwe <uw...@blue-yonder.com>
Date: 2016-11-09T12:02:20Z
DRILL-4979: Make port of the DataConnection configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #649: DRILL-4979: Make port of the DataConnection configurable
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/649
Thanks for the explanation.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #649: DRILL-4979: Make port of the DataConnection configu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #649: DRILL-4979: Make port of the DataConnection configurable
Posted by parthchandra <gi...@git.apache.org>.
Github user parthchandra commented on the issue:
https://github.com/apache/drill/pull/649
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #649: DRILL-4979: Make port of the DataConnection configurable
Posted by xhochy <gi...@git.apache.org>.
Github user xhochy commented on the issue:
https://github.com/apache/drill/pull/649
No, this patch is actually functioning as the data port is already included in the probuf: https://github.com/apache/drill/blob/master/protocol/src/main/protobuf/Coordination.proto#L11 The `+1 logic` is only used in the initialization code for the port.
Also I did a test run with 5 drillbits and random dataports assigned to them. They each were able to talk to them showing that the correct ports are communicated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---