You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "rtpsw (via GitHub)" <gi...@apache.org> on 2023/05/09 09:51:48 UTC
[GitHub] [arrow] rtpsw opened a new issue, #35507: [C++] Refactor debug-logging facilities in `AsofJoinNode`
rtpsw opened a new issue, #35507:
URL: https://github.com/apache/arrow/issues/35507
### Describe the enhancement requested
Following #34392, `AsofJoinNode` includes debug-logging facilities that should be refactored. The specific asks are:
1. [Move](https://github.com/apache/arrow/pull/34392#discussion_r1185225329) to a util file.
2. [Make](https://github.com/apache/arrow/pull/34392#issuecomment-1535793004) the debug-logging APIs generic to `ExecNode`.
3. [Extract](https://github.com/apache/arrow/pull/34392#discussion_r1187949299) debug-logging-enablement to query-context.
4. [Add](https://github.com/apache/arrow/pull/34392#discussion_r1187952001) an debug-logging API that automatically adds a new-line at the end.
5. [Investigate](https://github.com/apache/arrow/pull/34392#issuecomment-1539814758) GLOG.
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #35507: [C++] Refactor debug-logging facilities in `AsofJoinNode`
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #35507:
URL: https://github.com/apache/arrow/issues/35507#issuecomment-1540612920
Sadly, however, it seems that glog does not have category-specific logging and filtering, which would be nice. So maybe enabling fine-grained logging as part of the node options (with a default in query options) is the way to go after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rtpsw commented on issue #35507: [C++] Refactor debug-logging facilities in `AsofJoinNode`
Posted by "rtpsw (via GitHub)" <gi...@apache.org>.
rtpsw commented on issue #35507:
URL: https://github.com/apache/arrow/issues/35507#issuecomment-1541882234
Well, it's possible to work around this limitation, using macros that inject a message prefix and a custom logging sink that identifies the prefixes, but it would likely not be very nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] westonpace commented on issue #35507: [C++] Refactor debug-logging facilities in `AsofJoinNode`
Posted by "westonpace (via GitHub)" <gi...@apache.org>.
westonpace commented on issue #35507:
URL: https://github.com/apache/arrow/issues/35507#issuecomment-1540609371
Following up on your question about number 5.
You asked:
> Does GLOG allow collecting log messages in a buffer, so that the program could decide either to reset the buffer or flush it to the output stream? This is the main feature I needed here to avoid getting an enormous amount of debug-log messages due to the many successful test iterations that aren't relevant to the repro.
Glog can't do this out of the box. However, you can create a custom sink that could do this. We could register the custom sink (using a test environment) with googletest so it only spit out the logs if a test fails.
Docs on custom sinks: https://github.com/google/glog/blob/b70ea80433c2a8f20b832be97b90f1f82b0d29e9/src/glog/logging.h.in#L1750-L1795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Refactor debug-logging facilities in `AsofJoinNode` [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on issue #35507:
URL: https://github.com/apache/arrow/issues/35507#issuecomment-3921735940
This issue has been marked as stale because it has had no activity in the past 2 years. Please remove the stale label or comment below, or this issue will be closed in 14 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org