You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/10/18 15:14:55 UTC
[GitHub] [incubator-eventmesh] jinrongluo opened a new pull request #560: Dev secfix
jinrongluo opened a new pull request #560:
URL: https://github.com/apache/incubator-eventmesh/pull/560
Fixes ISSUE#554
### Motivation
removing hardcoded username and password
### Modifications
removing hardcoded username and password
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #560: [Issue#554] removing hardcoded username and password
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #560:
URL: https://github.com/apache/incubator-eventmesh/pull/560#issuecomment-945896699
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#560](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e685728) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/a4a4a9f90998c905f72f1505375fd75e08f98cb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4a4a9f) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #560 +/- ##
=============================================
- Coverage 11.08% 11.00% -0.09%
Complexity 391 391
=============================================
Files 263 263
Lines 12508 12490 -18
Branches 1046 1046
=============================================
- Hits 1386 1374 -12
+ Misses 11004 10998 -6
Partials 118 118
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../protocol/http/header/client/RegRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvUmVnUmVxdWVzdEhlYWRlci5qYXZh) | `65.71% <ø> (-0.96%)` | :arrow_down: |
| [...col/http/header/client/SubscribeRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvU3Vic2NyaWJlUmVxdWVzdEhlYWRlci5qYXZh) | `65.71% <ø> (-0.96%)` | :arrow_down: |
| [...l/http/header/client/UnSubscribeRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9jbGllbnQvVW5TdWJzY3JpYmVSZXF1ZXN0SGVhZGVyLmphdmE=) | `65.71% <ø> (-0.96%)` | :arrow_down: |
| [...http/header/message/PushMessageResponseHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9tZXNzYWdlL1B1c2hNZXNzYWdlUmVzcG9uc2VIZWFkZXIuamF2YQ==) | `59.09% <ø> (-1.21%)` | :arrow_down: |
| [...http/header/message/ReplyMessageRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9tZXNzYWdlL1JlcGx5TWVzc2FnZVJlcXVlc3RIZWFkZXIuamF2YQ==) | `65.71% <ø> (-0.96%)` | :arrow_down: |
| [.../header/message/SendMessageBatchRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9tZXNzYWdlL1NlbmRNZXNzYWdlQmF0Y2hSZXF1ZXN0SGVhZGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...eader/message/SendMessageBatchV2RequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9tZXNzYWdlL1NlbmRNZXNzYWdlQmF0Y2hWMlJlcXVlc3RIZWFkZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../http/header/message/SendMessageRequestHeader.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9wcm90b2NvbC9odHRwL2hlYWRlci9tZXNzYWdlL1NlbmRNZXNzYWdlUmVxdWVzdEhlYWRlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...e/eventmesh/client/http/conf/LiteClientConfig.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvY29uZi9MaXRlQ2xpZW50Q29uZmlnLmphdmE=) | `22.05% <ø> (-2.23%)` | :arrow_down: |
| [.../eventmesh/client/http/ssl/MyX509TrustManager.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXNkay1qYXZhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvY2xpZW50L2h0dHAvc3NsL015WDUwOVRydXN0TWFuYWdlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/560/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a4a4a9f...e685728](https://codecov.io/gh/apache/incubator-eventmesh/pull/560?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen merged pull request #560: [Issue#554] removing hardcoded username and password
Posted by GitBox <gi...@apache.org>.
qqeasonchen merged pull request #560:
URL: https://github.com/apache/incubator-eventmesh/pull/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #560: [Issue#554] removing hardcoded username and password
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on pull request #560:
URL: https://github.com/apache/incubator-eventmesh/pull/560#issuecomment-946322110
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] lrhkobe commented on pull request #560: [Issue#554] removing hardcoded username and password
Posted by GitBox <gi...@apache.org>.
lrhkobe commented on pull request #560:
URL: https://github.com/apache/incubator-eventmesh/pull/560#issuecomment-946529189
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org