Re: [PR] Fix Windowing/scanAndSort query issues on top of Joins. (druid)

["clintropolis (via GitHub)" <gi...@apache.org>]

clintropolis commented on code in PR #15996:
URL: https://github.com/apache/druid/pull/15996#discussion_r1510627892


##########
processing/src/main/java/org/apache/druid/frame/read/columnar/DoubleFrameColumnReader.java:
##########
@@ -67,7 +67,7 @@ public ColumnPlus readColumn(final Frame frame)
     return new ColumnPlus(
         frameCol,
         ColumnCapabilitiesImpl.createSimpleNumericColumnCapabilities(frameCol.getType())
-                              .setHasNulls(NullHandling.sqlCompatible() && frameCol.hasNulls),

Review Comment:
   the cast thing returning null is probably a bug (though its been a bug for so long that imo it isn't worth fixing in a deprecated mode), the native cast expression would spit out 0 from an expression selector if it actually ran...
   
   I think to not risk any inadvertent changes we shouldn't make this change for now if possible. Default value mode is deprecated and will be removed in a future release, so we should probably just leave things as they are whenever possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org