[GitHub] [rocketmq-connect] odbozhou commented on pull request #463: [rocketmq-replicator] Support create producer with connector's params…

["odbozhou (via GitHub)" <gi...@apache.org>]

odbozhou commented on PR #463:
URL: https://github.com/apache/rocketmq-connect/pull/463#issuecomment-1498946005

   In my opinion, this pr has some conflicts with the design of connect
   Here is my opinion
   1. There are two kinds of connectors: source and sink. The destination of the source is the RocketMQ cluster where the current Connector Worker cluster is located
   2. Worker configuration should come from connect.conf, just like broker configuration comes from broker.conf
   3. The connector's own configuration should not affect the configuration of the Worker
   4. As part of the rocketmq capability, the replicator can synchronize messages from other rocketmq clusters to the current cluster


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org