You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/07/09 05:09:21 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1217: Trigger clean and distclean for all directory which contain Makefile

xiaoxiang781216 opened a new pull request, #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217

   Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
   
   ## Summary
   
   ## Impact
   
   ## Testing
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217#issuecomment-1179781525

   > This was the old behavior, before filtering based on `.depend` and `.kconfig`. Do you want to bring it back? This will increase the execution time of multiple phases in build and configuration.
   
   Here is my thought:
   
   1. Compare with the compile and link, the time to execute clean/distclean is very small
   2. We need ensure the result is right before the optimization


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217#issuecomment-1180121583

   Compare with https://github.com/apache/incubator-nuttx-apps/pull/1214, the performance lose of this PR is huge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217#issuecomment-1180087074

   > We need ensure the result is right before applying the optimization
   
   Yes, sure, but I wanted to make sure that there is no other way except scanning all directories.
   When we had the nightly Jenkins build, that was building multiple configurations one after the other, this had a somewhat significant impact.   We don't use Jenkins anymore, and if this way is not properly working in all build modes, then yes we need to revert it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 closed pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #1217: Trigger clean and distclean for all directory which contain Makefile
URL: https://github.com/apache/nuttx-apps/pull/1217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 commented on pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #1217:
URL: https://github.com/apache/nuttx-apps/pull/1217#issuecomment-1457572979

   @Ouss4 either this patch or https://github.com/apache/nuttx-apps/pull/1632 is needed to fix the clean in the general case


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #1217:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1217#issuecomment-1179773206

   This was the old behavior, before filtering based on `.depend` and `.kconfig`.  Do you want to bring it back?  This will increase the execution time of multiple phases in build and configuration.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx-apps] xiaoxiang781216 closed pull request #1217: Trigger clean and distclean for all directory which contain Makefile

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 closed pull request #1217: Trigger clean and distclean for all directory which contain Makefile
URL: https://github.com/apache/nuttx-apps/pull/1217


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org