[GitHub] [pulsar] tisonkun commented on a diff in pull request #15129: [fix][broker] optimization getHostName correct when use broker ip in Kerberos authentication

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #15129:
URL: https://github.com/apache/pulsar/pull/15129#discussion_r1045077312


##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarServiceNameResolver.java:
##########
@@ -91,7 +91,7 @@ public void updateServiceUrl(String serviceUrl) throws InvalidServiceURL {
             String hostUrl = uri.getServiceScheme() + "://" + host;
             try {
                 URI hostUri = new URI(hostUrl);
-                addresses.add(InetSocketAddress.createUnresolved(hostUri.getHost(), hostUri.getPort()));
+                addresses.add(new InetSocketAddress(hostUri.getHost(), hostUri.getPort()));

Review Comment:
   This change can fail a number of tests. Please take a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org