You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Rajeshbabu Chintaguntla (Jira)" <ji...@apache.org> on 2023/11/30 03:43:00 UTC

[jira] [Created] (PHOENIX-7131) Honor omid.server.side.filter configuration while creating Omid Transactional Table

Rajeshbabu Chintaguntla created PHOENIX-7131:
------------------------------------------------

             Summary: Honor omid.server.side.filter configuration while creating Omid Transactional Table
                 Key: PHOENIX-7131
                 URL: https://issues.apache.org/jira/browse/PHOENIX-7131
             Project: Phoenix
          Issue Type: New Feature
            Reporter: Rajeshbabu Chintaguntla
            Assignee: Rajeshbabu Chintaguntla
             Fix For: 5.2.0, 5.1.4


Currently by default we are passing server side filter to be used as true always would be better to honor the configuration value of omid.server.side.filter while creating Omid TTable
{noformat}
    public OmidTransactionTable(PhoenixTransactionContext ctx, Table hTable, boolean isConflictFree, boolean addShadowCells) throws SQLException  {
       ....
        try {
            tTable = new TTable(hTable, true, isConflictFree);
        } catch (IOException e) {
       ....
    }
{noformat}

Would be better to use following constructor
{noformat}
    public TTable(Table hTable, boolean conflictFree) throws IOException {
        this(hTable, hTable.getConfiguration().getBoolean("omid.server.side.filter", false), conflictFree);
    }
{noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)