You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "bugmakerrrrrr (via GitHub)" <gi...@apache.org> on 2025/06/21 13:55:12 UTC
[PR] Optimize FieldExistsQuery to leverage index statistic in DocValuesSkipper [lucene]
bugmakerrrrrr opened a new pull request, #14830:
URL: https://github.com/apache/lucene/pull/14830
### Description
<!--
If this is your first contribution to Lucene, please make sure you have reviewed the contribution guide.
https://github.com/apache/lucene/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Optimize FieldExistsQuery to leverage index statistic in DocValuesSkipper [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz merged PR #14830:
URL: https://github.com/apache/lucene/pull/14830
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Optimize FieldExistsQuery to leverage index statistic in DocValuesSkipper [lucene]
Posted by "jpountz (via GitHub)" <gi...@apache.org>.
jpountz commented on code in PR #14830:
URL: https://github.com/apache/lucene/pull/14830#discussion_r2164950524
##########
lucene/core/src/test/org/apache/lucene/search/TestFieldExistsQuery.java:
##########
@@ -88,6 +88,25 @@ public void testDocValuesRewriteWithPointValuesPresent() throws IOException {
dir.close();
}
+ public void testDocValuesRewriteWithDocValuesSkipperPresent() throws IOException {
+ Directory dir = newDirectory();
+ RandomIndexWriter iw = new RandomIndexWriter(random(), dir);
+ final int numDocs = atLeast(100);
+ for (int i = 0; i < numDocs; ++i) {
+ Document doc = new Document();
+ doc.add(NumericDocValuesField.indexedField("dim", 2));
+ iw.addDocument(doc);
+ }
+ iw.commit();
+ final IndexReader reader = iw.getReader();
+ iw.close();
+
+ assertTrue(
+ (new FieldExistsQuery("dim")).rewrite(newSearcher(reader)) instanceof MatchAllDocsQuery);
Review Comment:
nit, maybe do `assertEquals(new MatchAllDocsQuery(), new FieldExistsQuery("dim")).rewrite(newSearcher(reader)))` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
Re: [PR] Optimize FieldExistsQuery to leverage index statistic in DocValuesSkipper [lucene]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14830:
URL: https://github.com/apache/lucene/pull/14830#issuecomment-2993596164
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org