[GitHub] [incubator-uniffle] xianjingfeng commented on a diff in pull request #294: [Improvement]Skip blocks when read from memory

[GitBox <gi...@apache.org>]

xianjingfeng commented on code in PR #294:
URL: https://github.com/apache/incubator-uniffle/pull/294#discussion_r1013587273


##########
server/src/main/java/org/apache/uniffle/server/buffer/ShuffleBuffer.java:
##########
@@ -121,13 +122,14 @@ public Map<Long, List<ShufflePartitionedBlock>> getInFlushBlockMap() {
   // 1. generate buffer segments and other info: if blockId exist, start with which eventId
   // 2. according to info from step 1, generate data
   // todo: if block was flushed, it's possible to get duplicated data
-  public synchronized ShuffleDataResult getShuffleData(
-      long lastBlockId, int readBufferSize) {
+  public ShuffleDataResult getShuffleData(

Review Comment:
   My mistake



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org