You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2025/04/08 16:39:35 UTC
[I] extended tests failing on main [datafusion]
alamb opened a new issue, #15641:
URL: https://github.com/apache/datafusion/issues/15641
### Describe the bug
extended tests are failing main
An example https://github.com/apache/datafusion/actions/runs/14331563613/job/40168564406
```
Compiling datafusion-sqllogictest v46.0.1 (/__w/datafusion/datafusion/datafusion/sqllogictest)
Finished `release-nonlto` profile [optimized] target(s) in 12m 21s
Running bin/sqllogictests.rs (target/release-nonlto/deps/sqllogictests-4e1c250[877](https://github.com/apache/datafusion/actions/runs/14331563613/job/40168564406#step:5:878)4cd153)
External error: query is expected to fail, but actually succeed:
[SQL] SELECT - 69 FROM tab0 WHERE + - col1 NOT IN ( - + col1, CAST ( + col0 AS INTEGER ), + + ( + + col1 ) / + - 0 * + col0 )
at ../../datafusion-testing/data/sqlite/random/aggregates/slt_good_11.slt:6360
External error: query is expected to fail, but actually succeed:
[SQL] SELECT DISTINCT col1 AS col1 FROM tab0 WHERE NOT + CASE + 87 WHEN col1 THEN col1 ELSE NULL END NOT BETWEEN - col1 / + col1 AND NULL GROUP BY col1 HAVING NOT col1 * 75 IS NOT NULL
at ../../datafusion-testing/data/sqlite/random/groupby/slt_good_12.slt:12141
```
### To Reproduce
You can run extended tests like this:
https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/README.md#running-tests-sqlite
### Expected behavior
- This started happening after https://github.com/apache/datafusion/pull/15462 was merged
I am not sure if this is expected or if it is a bug -- we'll have to look at what the test is doing
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #15641:
URL: https://github.com/apache/datafusion/issues/15641#issuecomment-2787460121
Thanks for confirming @Omega359 -- If you remake the files I can approve/merge it quickly !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb closed issue #15641: extended tests failing on main (External error: query is expected to fail, but actually succeed:)
URL: https://github.com/apache/datafusion/issues/15641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #15641:
URL: https://github.com/apache/datafusion/issues/15641#issuecomment-2787067276
Here is the query https://github.com/apache/datafusion-testing/blob/243047b9dd682be688628539c604daaddfe640f9/data/sqlite/random/aggregates/slt_good_11.slt#L6359-L6361
It may be that now that the code no longer runs the case causing a divide by zero because it was short circuted
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #15641:
URL: https://github.com/apache/datafusion/issues/15641#issuecomment-2787094771
> It may be that now that the code no longer runs the case causing a divide by zero because it was short circuted
Hmm. I can confirm that sql passes in Postgresql and Duckdb, both returning -69 (integer/int32)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #15641:
URL: https://github.com/apache/datafusion/issues/15641#issuecomment-2787098892
If no one gets to this I'll regenerate the sqlite files tonight
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] extended tests failing on main (External error: query is expected to fail, but actually succeed:) [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on issue #15641:
URL: https://github.com/apache/datafusion/issues/15641#issuecomment-2789263680
I made a PR to update the pin on main:
- https://github.com/apache/datafusion/pull/15655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org