You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2015/04/10 14:55:24 UTC
Review Request 33078: Reverting config (by clicking default) does not
revert changed configs warnings
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33078/
-----------------------------------------------------------
Review request for Ambari and Oleg Nechiporenko.
Bugs: AMBARI-10434
https://issues.apache.org/jira/browse/AMBARI-10434
Repository: ambari
Description
-------
STR
* Install cluster so that values are at the default values
* Change {{yarn.scheduler.minimum-allocation-mb}} from default 682 to 1024.
* The dependent configs correctly changed... their values derived from 1024.
* Now I clicked on the default triangle to set value to 682.
** I see 2 POST calls... one for 683 value, and one for 682
* I see {{yarn.scheduler.minimum-allocation-mb}} back to 682, but the service still says it has changed configs whose values are derived from 683.
When we revert to original value, and dependent configs revert to original values, the warnings should go away.
Diffs
-----
ambari-web/app/mixins/common/configs/enhanced_configs.js 1781d5dfb15aa6e06e292a7025bd794c533e6cd7
ambari-web/app/mixins/unit_convert/base_unit_convert_mixin.js 4ba70a3868910a31099bf5774a919f4b6a19968a
ambari-web/app/views/common/configs/widgets/config_widget_view.js 85987542ab60a25e50945c6d0f25c2811ea251b2
ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js 6cb0602b8e877cb97be339dfd8f23cb664b6b614
ambari-web/app/views/common/controls_view.js b661a8bf691a384390128d39b1d3c4a11a61d91e
ambari-web/test/views/common/configs/widgets/config_widget_view_test.js 9d0f7db27480c3029f24bb4dff06d3a436dfe571
ambari-web/test/views/common/configs/widgets/list_config_widget_view_test.js 01e184a2eb4138a0b073f89e00d8bfe4674e1166
Diff: https://reviews.apache.org/r/33078/diff/
Testing
-------
5782 tests complete (9 seconds)
78 tests pending
Thanks,
Andriy Babiichuk
Re: Review Request 33078: Reverting config (by clicking default) does
not revert changed configs warnings
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33078/#review79675
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On April 10, 2015, 12:55 p.m., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33078/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:55 p.m.)
>
>
> Review request for Ambari and Oleg Nechiporenko.
>
>
> Bugs: AMBARI-10434
> https://issues.apache.org/jira/browse/AMBARI-10434
>
>
> Repository: ambari
>
>
> Description
> -------
>
> STR
> * Install cluster so that values are at the default values
> * Change {{yarn.scheduler.minimum-allocation-mb}} from default 682 to 1024.
> * The dependent configs correctly changed... their values derived from 1024.
> * Now I clicked on the default triangle to set value to 682.
> ** I see 2 POST calls... one for 683 value, and one for 682
> * I see {{yarn.scheduler.minimum-allocation-mb}} back to 682, but the service still says it has changed configs whose values are derived from 683.
>
> When we revert to original value, and dependent configs revert to original values, the warnings should go away.
>
>
> Diffs
> -----
>
> ambari-web/app/mixins/common/configs/enhanced_configs.js 1781d5dfb15aa6e06e292a7025bd794c533e6cd7
> ambari-web/app/mixins/unit_convert/base_unit_convert_mixin.js 4ba70a3868910a31099bf5774a919f4b6a19968a
> ambari-web/app/views/common/configs/widgets/config_widget_view.js 85987542ab60a25e50945c6d0f25c2811ea251b2
> ambari-web/app/views/common/configs/widgets/slider_config_widget_view.js 6cb0602b8e877cb97be339dfd8f23cb664b6b614
> ambari-web/app/views/common/controls_view.js b661a8bf691a384390128d39b1d3c4a11a61d91e
> ambari-web/test/views/common/configs/widgets/config_widget_view_test.js 9d0f7db27480c3029f24bb4dff06d3a436dfe571
> ambari-web/test/views/common/configs/widgets/list_config_widget_view_test.js 01e184a2eb4138a0b073f89e00d8bfe4674e1166
>
> Diff: https://reviews.apache.org/r/33078/diff/
>
>
> Testing
> -------
>
> 5782 tests complete (9 seconds)
> 78 tests pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>