You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/09/13 07:05:01 UTC
[GitHub] [incubator-pinot] codecov-io commented on issue #4612: Add column
types info to the selection and aggregation query results.
codecov-io commented on issue #4612: Add column types info to the selection and aggregation query results.
URL: https://github.com/apache/incubator-pinot/pull/4612#issuecomment-531124397
# [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=h1) Report
> Merging [#4612](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/fe7fff6288464aaf430ab850741000481fa704fc?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `80%`.
[](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4612 +/- ##
============================================
+ Coverage 64.33% 64.36% +0.02%
+ Complexity 94 32 -62
============================================
Files 1072 1072
Lines 55702 55723 +21
Branches 8131 8133 +2
============================================
+ Hits 35836 35865 +29
+ Misses 17216 17214 -2
+ Partials 2650 2644 -6
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...t/core/query/selection/SelectionOperatorUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JVdGlscy5qYXZh) | `88.32% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...e/pinot/core/query/reduce/BrokerReduceService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQnJva2VyUmVkdWNlU2VydmljZS5qYXZh) | `80.52% <100%> (+0.37%)` | `0 <0> (ø)` | :arrow_down: |
| [...inot/common/response/broker/AggregationResult.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL0FnZ3JlZ2F0aW9uUmVzdWx0LmphdmE=) | `69.23% <100%> (+9.23%)` | `0 <0> (ø)` | :arrow_down: |
| [...pinot/common/response/broker/SelectionResults.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvYnJva2VyL1NlbGVjdGlvblJlc3VsdHMuamF2YQ==) | `62.5% <50%> (-17.5%)` | `0 <0> (ø)` | |
| [...core/query/selection/SelectionOperatorService.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9zZWxlY3Rpb24vU2VsZWN0aW9uT3BlcmF0b3JTZXJ2aWNlLmphdmE=) | `46.78% <66.66%> (+0.06%)` | `0 <0> (ø)` | :arrow_down: |
| [...java/org/apache/pinot/common/utils/DataSchema.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `84% <85.71%> (+0.12%)` | `0 <0> (ø)` | :arrow_down: |
| [...a/manager/realtime/RealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVTZWdtZW50RGF0YU1hbmFnZXIuamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...impl/dictionary/DoubleOnHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT25IZWFwTXV0YWJsZURpY3Rpb25hcnkuamF2YQ==) | `65.21% <0%> (-10.87%)` | `0% <0%> (ø)` | |
| [...mpl/dictionary/DoubleOffHeapMutableDictionary.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yZWFsdGltZS9pbXBsL2RpY3Rpb25hcnkvRG91YmxlT2ZmSGVhcE11dGFibGVEaWN0aW9uYXJ5LmphdmE=) | `67.85% <0%> (-10.72%)` | `0% <0%> (ø)` | |
| [...org/apache/pinot/broker/queryquota/HitCounter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcXVlcnlxdW90YS9IaXRDb3VudGVyLmphdmE=) | `92.3% <0%> (-7.7%)` | `0% <0%> (ø)` | |
| ... and [20 more](https://codecov.io/gh/apache/incubator-pinot/pull/4612/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=footer). Last update [fe7fff6...fe93380](https://codecov.io/gh/apache/incubator-pinot/pull/4612?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org