You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Aditi Dixit <ad...@gmail.com> on 2015/04/08 15:35:36 UTC

Re: Review Request 32967: Cleaned upstyle and comments in modules.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32967/
-----------------------------------------------------------

(Updated April 8, 2015, 1:35 p.m.)


Review request for mesos, Alexander Rukletsov and Kapil Arya.


Summary (updated)
-----------------

Cleaned upstyle and comments in modules.


Bugs: MESOS-2565
    https://issues.apache.org/jira/browse/MESOS-2565


Repository: mesos


Description (updated)
-------

Fixed minor style issues in modules and the misleading comments.


Diffs
-----

  include/mesos/module/authenticatee.hpp 94de988d524d6390a9f59edbc61f1f7cae514efd 
  include/mesos/module/authenticator.hpp 6a83f17b76ab0bf7af8acd3ddb8044f1bdfa78c0 
  include/mesos/module/hook.hpp a474e2bd118a5451c0574e33e2cbe9d7d7e95fce 
  include/mesos/module/isolator.hpp 452ad318b9d5445860fa49bcdb933925d750f900 
  src/examples/test_anonymous_module.cpp 859f4e19e0d50794172af4cff708edf171e6d02f 
  src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
  src/examples/test_isolator_module.cpp 2c303f5ff2f17d56a840a5e0108281873c17ce6a 
  src/examples/test_module.hpp 041570ef3af338bc51c3b3218c460cc8b3f4e4de 

Diff: https://reviews.apache.org/r/32967/diff/


Testing
-------

make check


Thanks,

Aditi Dixit


Re: Review Request 32967: Cleaned upstyle and comments in modules.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32967/#review79348
-----------------------------------------------------------

Ship it!


Ship It!

- Kapil Arya


On April 8, 2015, 9:35 a.m., Aditi Dixit wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32967/
> -----------------------------------------------------------
> 
> (Updated April 8, 2015, 9:35 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kapil Arya.
> 
> 
> Bugs: MESOS-2565
>     https://issues.apache.org/jira/browse/MESOS-2565
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fixed minor style issues in modules and the misleading comments.
> 
> 
> Diffs
> -----
> 
>   include/mesos/module/authenticatee.hpp 94de988d524d6390a9f59edbc61f1f7cae514efd 
>   include/mesos/module/authenticator.hpp 6a83f17b76ab0bf7af8acd3ddb8044f1bdfa78c0 
>   include/mesos/module/hook.hpp a474e2bd118a5451c0574e33e2cbe9d7d7e95fce 
>   include/mesos/module/isolator.hpp 452ad318b9d5445860fa49bcdb933925d750f900 
>   src/examples/test_anonymous_module.cpp 859f4e19e0d50794172af4cff708edf171e6d02f 
>   src/examples/test_hook_module.cpp 47409cd4d02e238d1d182571d92019114662cd41 
>   src/examples/test_isolator_module.cpp 2c303f5ff2f17d56a840a5e0108281873c17ce6a 
>   src/examples/test_module.hpp 041570ef3af338bc51c3b3218c460cc8b3f4e4de 
> 
> Diff: https://reviews.apache.org/r/32967/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Aditi Dixit
> 
>