[GitHub] [hive] sunchao commented on a change in pull request #2459: HIVE-25317: Relocate dependencies in shaded hive-exec module

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #2459:
URL: https://github.com/apache/hive/pull/2459#discussion_r710369202



##########
File path: llap-server/pom.xml
##########
@@ -38,6 +38,7 @@
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-exec</artifactId>
       <version>${project.version}</version>
+      <classifier>core</classifier>

Review comment:
       @kgyrtkirk Guava is shaded in branch-2.3 via https://issues.apache.org/jira/browse/HIVE-23980. The issue is, in order for Spark to use shaded `hive-exec`, Hive will need to relocate more classes and at the same time making sure it won't break other modules (for instance, if the shaded class appears in certain API and another module imported the unshaded version of the class by itself).
   
   Currently we've abandoned this approach and decided to shade the `hive-exec-core` within Spark itself, following similar approach in Trino (see https://github.com/trinodb/trino-hive-apache).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org