You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/03/08 17:16:01 UTC

[GitHub] [accumulo] dlmarion commented on a change in pull request #2547: Standardized Thread subclasses to Threads class standards

dlmarion commented on a change in pull request #2547:
URL: https://github.com/apache/accumulo/pull/2547#discussion_r821888951



##########
File path: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCache.java
##########
@@ -520,7 +521,7 @@ public long getEvictedCount() {
 
     public EvictionThread(LruBlockCache cache) {
       super("LruBlockCache.EvictionThread");
-      setDaemon(true);
+      Threads.applyStandardsToThread(this, "LruBlockCache.EvictionThread");

Review comment:
       So, I could not turn that into a Runnable due to the fact that this Thread objects' `evict()` method is called elsewhere in the class. So, I created an Accumulo subclass of Thread in 40a1945c60dbfdef01170f1a4b79136d6f83d91f and modified the classes in this PR to extend it instead of Thread.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org