You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/10/16 06:34:35 UTC
Review Request 39376: Windows: Prepared agent for Windows support of
`process/socket.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/
-----------------------------------------------------------
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
In particular, we will remove the inclusion of `stout/os.hpp` from
`process/socket.hpp`, which will cause a couple of files to break. Our
solution to this problem is to include `os.hpp` directly in those files.
Diffs
-----
src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
src/slave/containerizer/composing.cpp 8c3a2353999523ef055332320443931b61843d21
src/slave/containerizer/isolators/cgroups/mem.cpp 6f49e5ac77ab03248127a607664c8f895be72877
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f
Diff: https://reviews.apache.org/r/39376/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39376: Windows: Prepared agent for Windows support
of `process/socket.hpp`.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/#review103275
-----------------------------------------------------------
Ship it!
- Joris Van Remoortere
On Oct. 19, 2015, 11:25 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39376/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 11:25 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In particular, we will remove the inclusion of `stout/os.hpp` from
> `process/socket.hpp`, which will cause a couple of files to break. Our
> solution to this problem is to include `os.hpp` directly in those files.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
> src/slave/containerizer/composing.cpp 8c3a2353999523ef055332320443931b61843d21
> src/slave/containerizer/isolators/cgroups/mem.cpp 6f49e5ac77ab03248127a607664c8f895be72877
> src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
> src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f
>
> Diff: https://reviews.apache.org/r/39376/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39376: Windows: Prepared agent for Windows support
of `process/socket.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/
-----------------------------------------------------------
(Updated Oct. 19, 2015, 11:25 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
In particular, we will remove the inclusion of `stout/os.hpp` from
`process/socket.hpp`, which will cause a couple of files to break. Our
solution to this problem is to include `os.hpp` directly in those files.
Diffs (updated)
-----
src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
src/slave/containerizer/composing.cpp 8c3a2353999523ef055332320443931b61843d21
src/slave/containerizer/isolators/cgroups/mem.cpp 6f49e5ac77ab03248127a607664c8f895be72877
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f
Diff: https://reviews.apache.org/r/39376/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39376: Windows: Prepared agent for Windows support
of `process/socket.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/
-----------------------------------------------------------
(Updated Oct. 16, 2015, 7:50 p.m.)
Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
Repository: mesos
Description
-------
In particular, we will remove the inclusion of `stout/os.hpp` from
`process/socket.hpp`, which will cause a couple of files to break. Our
solution to this problem is to include `os.hpp` directly in those files.
Diffs (updated)
-----
src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
src/slave/containerizer/composing.cpp 8c3a2353999523ef055332320443931b61843d21
src/slave/containerizer/isolators/cgroups/mem.cpp 6f49e5ac77ab03248127a607664c8f895be72877
src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f
Diff: https://reviews.apache.org/r/39376/diff/
Testing
-------
CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
Autotools `make check` on Ubuntu 15.
Thanks,
Alex Clemmer
Re: Review Request 39376: Windows: Prepared agent for Windows support
of `process/socket.hpp`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39376/#review102971
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Oct. 15, 2015, 9:34 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39376/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 9:34 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In particular, we will remove the inclusion of `stout/os.hpp` from
> `process/socket.hpp`, which will cause a couple of files to break. Our
> solution to this problem is to include `os.hpp` directly in those files.
>
>
> Diffs
> -----
>
> src/linux/perf.cpp f7035ddb2507a7646d88dd517d048018f695448a
> src/slave/containerizer/composing.cpp 8c3a2353999523ef055332320443931b61843d21
> src/slave/containerizer/isolators/cgroups/mem.cpp 6f49e5ac77ab03248127a607664c8f895be72877
> src/slave/containerizer/provisioner/docker/registry_client.cpp 471783d88b73b62afacac3d7952ebb5d5f442097
> src/zookeeper/zookeeper.cpp e44403ee91904415471382dfa4e0a6e0adfdb74f
>
> Diff: https://reviews.apache.org/r/39376/diff/
>
>
> Testing
> -------
>
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 on Windows 10.
>
> Autotools `make check` on Ubuntu 15.
>
>
> Thanks,
>
> Alex Clemmer
>
>