You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/12 22:43:30 UTC
[GitHub] [pulsar] sijie opened a new pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
sijie opened a new pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549
*Motivation*
Fixes #6748
This is a fork of #6757 after rebased to the latest master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-727123412
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-727297280
> @Jennifer88huang No. It should impact the releases onwards.
Got it, thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-728858867
```
Error: Tests run: 4, Failures: 2, Errors: 0, Skipped: 2, Time elapsed: 73.116 s <<< FAILURE! - in TestSuite
Error: pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto) Time elapsed: 1.03 s <<< FAILURE!
org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 6f4ea4f7267b7a375cfa1742c06a06c7a7a7ac24e9b2b4e91731c3ffede237dd with error code 1
at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259)
at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51)
at com.github.dockerjava.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$4(OkHttpInvocationBuilder.java:331)
at java.lang.Thread.run(Thread.java:748)
Error: pulsar-test-suite(org.apache.pulsar.tests.integration.presto.TestBasicPresto) Time elapsed: 1.015 s <<< FAILURE!
org.apache.pulsar.tests.integration.docker.ContainerExecException: /bin/bash -c /pulsar/bin/pulsar sql --execute 'show catalogs;' failed on 6f4ea4f7267b7a375cfa1742c06a06c7a7a7ac24e9b2b4e91731c3ffede237dd with error code 1
at org.apache.pulsar.tests.integration.utils.DockerUtils$2.onComplete(DockerUtils.java:259)
at com.github.dockerjava.core.exec.AbstrAsyncDockerCmdExec$1.onComplete(AbstrAsyncDockerCmdExec.java:51)
at com.github.dockerjava.okhttp.OkHttpInvocationBuilder.lambda$executeAndStream$4(OkHttpInvocationBuilder.java:331)
at java.lang.Thread.run(Thread.java:748)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jennifer88huang commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
Jennifer88huang commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-726503366
Since the issue was first raised in April, we should adopt the doc changes ever since 2.5.1 release. How about releases earlier than 2.5.1?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-728580536
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-751971860
Hi @sijie could you please help resolve the conflicts? And then we can merge this PR, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-753786004
@sijie any progress on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549#issuecomment-727045352
@Jennifer88huang No. It should impact the releases onwards.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #8549: Issue 6478: Fix the misleading setting in presto configuration
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #8549:
URL: https://github.com/apache/pulsar/pull/8549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org